You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by si...@apache.org on 2019/04/21 14:09:25 UTC
[pulsar] branch master updated: Make generate_protobuf_docker.sh
usable on windows (#4020)
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 8b1c338 Make generate_protobuf_docker.sh usable on windows (#4020)
8b1c338 is described below
commit 8b1c33814d2741df95fa16515e4f3cf5f6086d57
Author: Ever <ie...@outlook.com>
AuthorDate: Sun Apr 21 22:09:21 2019 +0800
Make generate_protobuf_docker.sh usable on windows (#4020)
### Motivation
On windows, `generate_protobuf_docker.sh` cannot work well, because a ':' is contained in windows path. Just make it work.
### Modifications
change generate_protobuf_docker.sh
---
pulsar-common/generate_protobuf_docker.sh | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/pulsar-common/generate_protobuf_docker.sh b/pulsar-common/generate_protobuf_docker.sh
index 376d72e..52b9d66 100755
--- a/pulsar-common/generate_protobuf_docker.sh
+++ b/pulsar-common/generate_protobuf_docker.sh
@@ -35,6 +35,8 @@ echo $IMAGE
# Force to pull image in case it was updated
docker pull $IMAGE
+WORKDIR=/workdir
docker run -i \
- -v ${COMMON_DIR}:${COMMON_DIR} $IMAGE \
- bash -c "cd ${COMMON_DIR}; /pulsar/protobuf/src/protoc --java_out=src/main/java src/main/proto/PulsarApi.proto"
+ -v ${COMMON_DIR}:${WORKDIR} $IMAGE \
+ bash -c "cd ${WORKDIR}; /pulsar/protobuf/src/protoc --java_out=src/main/java src/main/proto/PulsarApi.proto"
+