You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/12/28 09:44:09 UTC
[GitHub] [commons-codec] Claudenw opened a new pull request #34: Added
javadoc messages concerning hash64 seed and sign extension.
Claudenw opened a new pull request #34: Added javadoc messages concerning hash64 seed and sign extension.
URL: https://github.com/apache/commons-codec/pull/34
Fix for CODEC-275
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-codec] garydgregory commented on issue #34: Added javadoc
messages concerning hash64 seed and sign extension.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #34: Added javadoc messages concerning hash64 seed and sign extension.
URL: https://github.com/apache/commons-codec/pull/34#issuecomment-569429974
I am going to bring this in because it helps understand the code more, especially since these comments are all on deprecated methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-codec] garydgregory merged pull request #34: Added javadoc
messages concerning hash64 seed and sign extension.
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #34: Added javadoc messages concerning hash64 seed and sign extension.
URL: https://github.com/apache/commons-codec/pull/34
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-codec] aherbert commented on issue #34: Added javadoc
messages concerning hash64 seed and sign extension.
Posted by GitBox <gi...@apache.org>.
aherbert commented on issue #34: Added javadoc messages concerning hash64 seed and sign extension.
URL: https://github.com/apache/commons-codec/pull/34#issuecomment-569404502
I am 50/50 on this.
I would not call it a bug when there is no reference hash64 implementation. This method is a port of a bad adaption of the hash128x86 method to output a 64-bit hash. So unlike the other method where it was a bug because the output was not the same as the reference implementation, this can be labelled as an implementation detail.
The only real effect is that the initial hash will be xor'd with 1's instead of 0's for the upper 32-bits and if the seed is negative.
Since we do not know about the statistical properties of this hash, it is not part of the original code and it is marked as deprecated then adding a lot of javadoc about sign-extension bugs which do not manifest (because the default seed is positive) to 5 deprecated methods seems like noise to me.
I would update the javadoc on the main method which accepts a seed to state that the seed is **not** treated as **unsigned**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-codec] garydgregory commented on issue #34: Added javadoc
messages concerning hash64 seed and sign extension.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #34: Added javadoc messages concerning hash64 seed and sign extension.
URL: https://github.com/apache/commons-codec/pull/34#issuecomment-569430211
https://issues.apache.org/jira/browse/CODEC-275
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-codec] coveralls commented on issue #34: Added javadoc
messages concerning hash64 seed and sign extension.
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #34: Added javadoc messages concerning hash64 seed and sign extension.
URL: https://github.com/apache/commons-codec/pull/34#issuecomment-569402938
[](https://coveralls.io/builds/27823212)
Coverage remained the same at 93.321% when pulling **ee892271ea5945c67acf48bbf0e0a6886a688afd on Claudenw:CODEC-275_Update_javadoc** into **e4de423b8a197cf1f178256a2b65b28a6f8fe355 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services