You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/10/09 03:10:01 UTC

[PR] [MINOR][PYTHON][TESTS] Reduce the python worker error log of `test_toDF_with_schema_string` [spark]

zhengruifeng opened a new pull request, #48388:
URL: https://github.com/apache/spark/pull/48388

   ### What changes were proposed in this pull request?
   Reduce the python worker error log of `test_toDF_with_schema_string`
   
   
   ### Why are the changes needed?
   When I run the test locally
   ```python
   python/run-tests -k --python-executables python3 --testnames 'pyspark.sql.tests.test_dataframe'
   ```
   
   Two assertions in `test_toDF_with_schema_string` generate too many python worker error logs (~1k lines), which easily exceed the limitation of terminal and make it hard to debug.
   
   So I want to reduce the number of python workers in the two assertions.
   
   
   ### Does this PR introduce _any_ user-facing change?
   no, test only
   
   
   ### How was this patch tested?
   manually test, the logs will be reduced to ~200 lines
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [MINOR][PYTHON][TESTS] Reduce the python worker error log of `test_toDF_with_schema_string` [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48388:
URL: https://github.com/apache/spark/pull/48388#issuecomment-2403611392

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [MINOR][PYTHON][TESTS] Reduce the python worker error log of `test_toDF_with_schema_string` [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #48388: [MINOR][PYTHON][TESTS] Reduce the python worker error log of `test_toDF_with_schema_string`
URL: https://github.com/apache/spark/pull/48388


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org