You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/10/10 21:19:38 UTC
Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26571/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1797
https://issues.apache.org/jira/browse/MESOS-1797
Repository: mesos-git
Description
-------
Fixes build issue caused by htonll introduced by OSX 10.10 (Yosemite).
This patch has been submitted upstream as well:
https://issues.apache.org/jira/browse/ZOOKEEPER-2049
This patch shall not be committed until upstream has accepted it - I will update this accordingly.
Diffs
-----
3rdparty/zookeeper-3.4.5.patch PRE-CREATION
Diff: https://reviews.apache.org/r/26571/diff/
Testing
-------
make check (OSX 10.10 BETA5)
Thanks,
Till Toenshoff
Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26571/#review56957
-----------------------------------------------------------
Ship it!
Thanks Till!
- Jiang Yan Xu
On Oct. 16, 2014, 3:13 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26571/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 3:13 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1797
> https://issues.apache.org/jira/browse/MESOS-1797
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes build issue caused by htonll introduced by OSX 10.10 (Yosemite).
>
> This poses as a hotfix to prevent us from having to upgrade the bundled ZooKeeper altogether to prevent longer regression testing. Once ZooKeeper does get updated into a recent version (3.4.x >= 3.4.7, 3.5.x >= 3.5.1 or >= 3.6.0), this patch should get removed.
>
>
> Diffs
> -----
>
> 3rdparty/zookeeper-3.4.5.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26571/diff/
>
>
> Testing
> -------
>
> make check (OSX 10.10 BETA5)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26571/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 10:13 a.m.)
Review request for mesos.
Changes
-------
Updated description to reflect latest upstream status as well as a "best before date".
Bugs: MESOS-1797
https://issues.apache.org/jira/browse/MESOS-1797
Repository: mesos-git
Description (updated)
-------
Fixes build issue caused by htonll introduced by OSX 10.10 (Yosemite).
This poses as a hotfix to prevent us from having to upgrade the bundled ZooKeeper altogether to prevent longer regression testing. Once ZooKeeper does get updated into a recent version (3.4.x >= 3.4.7, 3.5.x >= 3.5.1 or >= 3.6.0), this patch should get removed.
Diffs
-----
3rdparty/zookeeper-3.4.5.patch PRE-CREATION
Diff: https://reviews.apache.org/r/26571/diff/
Testing
-------
make check (OSX 10.10 BETA5)
Thanks,
Till Toenshoff
Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.
Posted by Till Toenshoff <to...@me.com>.
> On Oct. 10, 2014, 10:01 p.m., Vinod Kone wrote:
> > Till, can you find a shepherd for this issue (@yan ?) and make him the reviewer?
Aye, reached out to him on the jira.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26571/#review56234
-----------------------------------------------------------
On Oct. 10, 2014, 7:19 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26571/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2014, 7:19 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1797
> https://issues.apache.org/jira/browse/MESOS-1797
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes build issue caused by htonll introduced by OSX 10.10 (Yosemite).
>
> This patch has been submitted upstream as well:
> https://issues.apache.org/jira/browse/ZOOKEEPER-2049
>
> This patch shall not be committed until upstream has accepted it - I will update this accordingly.
>
>
> Diffs
> -----
>
> 3rdparty/zookeeper-3.4.5.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26571/diff/
>
>
> Testing
> -------
>
> make check (OSX 10.10 BETA5)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26571/#review56234
-----------------------------------------------------------
Till, can you find a shepherd for this issue (@yan ?) and make him the reviewer?
- Vinod Kone
On Oct. 10, 2014, 7:19 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26571/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2014, 7:19 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1797
> https://issues.apache.org/jira/browse/MESOS-1797
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes build issue caused by htonll introduced by OSX 10.10 (Yosemite).
>
> This patch has been submitted upstream as well:
> https://issues.apache.org/jira/browse/ZOOKEEPER-2049
>
> This patch shall not be committed until upstream has accepted it - I will update this accordingly.
>
>
> Diffs
> -----
>
> 3rdparty/zookeeper-3.4.5.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26571/diff/
>
>
> Testing
> -------
>
> make check (OSX 10.10 BETA5)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26571/#review56221
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26571]
All tests passed.
- Mesos ReviewBot
On Oct. 10, 2014, 7:19 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26571/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2014, 7:19 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1797
> https://issues.apache.org/jira/browse/MESOS-1797
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes build issue caused by htonll introduced by OSX 10.10 (Yosemite).
>
> This patch has been submitted upstream as well:
> https://issues.apache.org/jira/browse/ZOOKEEPER-2049
>
> This patch shall not be committed until upstream has accepted it - I will update this accordingly.
>
>
> Diffs
> -----
>
> 3rdparty/zookeeper-3.4.5.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26571/diff/
>
>
> Testing
> -------
>
> make check (OSX 10.10 BETA5)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.
Posted by Till Toenshoff <to...@me.com>.
> On Oct. 13, 2014, 6:21 a.m., Jiang Yan Xu wrote:
> > LGTM. Let's see how ZOOKEEPER-2049 is going.
Patch got accepted and committed into zookeeper.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26571/#review56380
-----------------------------------------------------------
On Oct. 10, 2014, 7:19 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26571/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2014, 7:19 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1797
> https://issues.apache.org/jira/browse/MESOS-1797
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes build issue caused by htonll introduced by OSX 10.10 (Yosemite).
>
> This patch has been submitted upstream as well:
> https://issues.apache.org/jira/browse/ZOOKEEPER-2049
>
> This patch shall not be committed until upstream has accepted it - I will update this accordingly.
>
>
> Diffs
> -----
>
> 3rdparty/zookeeper-3.4.5.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26571/diff/
>
>
> Testing
> -------
>
> make check (OSX 10.10 BETA5)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26571/#review56380
-----------------------------------------------------------
LGTM. Let's see how ZOOKEEPER-2049 is going.
- Jiang Yan Xu
On Oct. 10, 2014, 12:19 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26571/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2014, 12:19 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1797
> https://issues.apache.org/jira/browse/MESOS-1797
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes build issue caused by htonll introduced by OSX 10.10 (Yosemite).
>
> This patch has been submitted upstream as well:
> https://issues.apache.org/jira/browse/ZOOKEEPER-2049
>
> This patch shall not be committed until upstream has accepted it - I will update this accordingly.
>
>
> Diffs
> -----
>
> 3rdparty/zookeeper-3.4.5.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26571/diff/
>
>
> Testing
> -------
>
> make check (OSX 10.10 BETA5)
>
>
> Thanks,
>
> Till Toenshoff
>
>