You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Carlos Valiente (JIRA)" <ji...@apache.org> on 2008/11/11 21:27:44 UTC
[jira] Created: (THRIFT-199) Integrate lib/perl into automake
Integrate lib/perl into automake
--------------------------------
Key: THRIFT-199
URL: https://issues.apache.org/jira/browse/THRIFT-199
Project: Thrift
Issue Type: Improvement
Components: Library (Perl)
Affects Versions: 0.1
Reporter: Carlos Valiente
Priority: Minor
Fix For: 0.1
Attachments: perl-automake.diff
This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-199) Integrate lib/perl into automake
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani resolved THRIFT-199.
-----------------------------------
Resolution: Fixed
comitted
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.1
>
> Attachments: perl-automake-v2.diff, perl-automake-v3.diff, perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-199) Integrate lib/perl into automake
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani reassigned THRIFT-199:
-------------------------------------
Assignee: T Jake Luciani
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.1
>
> Attachments: perl-automake-v2.diff, perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-199) Integrate lib/perl into automake
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664373#action_12664373 ]
T Jake Luciani commented on THRIFT-199:
---------------------------------------
Hey Carlos,
I'm trying to run the tests and it's failing because TAP::Harness isn't availible.
Do you mind if i switch it to Test::Harness? This works.
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.1
>
> Attachments: perl-automake-v2.diff, perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-199) Integrate lib/perl into automake
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-199.
--------------------------------
Resolution: Fixed
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-199.-perl-Let-make-distclean-work-when-we.patch, perl-automake-v2.diff, perl-automake-v3.diff, perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-199) Integrate lib/perl into automake
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664628#action_12664628 ]
David Reiss commented on THRIFT-199:
------------------------------------
The automake stuff looks pretty good. There are a few changes that I'd like to see, though.
- Please rename Makefile.perl, since its extension implies that it is a Perl source file. The convention for Makefiles that can't be named "Makefile" is ".mk". So maybe something like "Makefile-PL.mk"?
- Please use "$(MAKE)" instead of "${MAKE}" because it is consistent with the style of our other Makefiles.
- Please combine the two Makefile.am under lib into the top one. EXTRA_DIST can reference files in subdirs, so there is no need for the extra Makefiles.
- Please put every file in EXTRA_DIST on its own line (with backslashes).
- Please use @topbuilddir@ instead of @builddir/../../.. in the test makefile.
- Under the test Makefile, can you eliminate the thrift_done file with something like
{code}
all-local: gen-perl/ThriftTest/Types.pm
gen-perl/ThriftTest_types.pl: $(THRIFT_IF)
$(THRIFT) --gen perl $(THRIFT_IF)
{code}
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.1
>
> Attachments: perl-automake-v2.diff, perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-199) Integrate lib/perl into automake
Posted by "Carlos Valiente (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Valiente updated THRIFT-199:
-----------------------------------
Attachment: perl-automake-v3.diff
Thanks for the feedback, David. perl-automake-v3.diff now includes all your suggestions, plus:
- The change ftom TAP::Harness to Test::Harness suggested by Jake, and
- Some svn:ignore properties under lib/perl
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.1
>
> Attachments: perl-automake-v2.diff, perl-automake-v3.diff, perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-199) Integrate lib/perl into automake
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681892#action_12681892 ]
David Reiss commented on THRIFT-199:
------------------------------------
So, the Makefile.am in this commit includes "MANIFEST" in EXTRA_DIST, but the file doesn't actually exist. EXTRA_DIST is for extra files in the source tree that are meant to be included in the release tarball. Does MANIFEST really need to be in the release tarball, or can I remove it from the list?
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-199.-perl-Let-make-distclean-work-when-we.patch, perl-automake-v2.diff, perl-automake-v3.diff, perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-199) Integrate lib/perl into automake
Posted by "Carlos Valiente (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664440#action_12664440 ]
Carlos Valiente commented on THRIFT-199:
----------------------------------------
No problem, Jake, go ahead with Test::Harness. Thanks!
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.1
>
> Attachments: perl-automake-v2.diff, perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-199) Integrate lib/perl into automake
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-199:
-------------------------------
Attachment: 0001-THRIFT-199.-perl-Let-make-distclean-work-when-we.patch
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-199.-perl-Let-make-distclean-work-when-we.patch, perl-automake-v2.diff, perl-automake-v3.diff, perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-199) Integrate lib/perl into automake
Posted by "Carlos Valiente (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682022#action_12682022 ]
Carlos Valiente commented on THRIFT-199:
----------------------------------------
bq. Does MANIFEST really need to be in the release tarball, or can I remove it from the list?
Looks like 'make install' works without MANIFEST (at least on my Ubuntu 8.04 installation), so it is not needed in EXTRA_DIST.
I should have checked my patches on a clean Subversion setup - sorry about that :-(
C
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-199.-perl-Let-make-distclean-work-when-we.patch, perl-automake-v2.diff, perl-automake-v3.diff, perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-199) Integrate lib/perl into automake
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662827#action_12662827 ]
Esteve Fernandez commented on THRIFT-199:
-----------------------------------------
The patch looks good, but I would add some tests under test/perl to ensure that the library works fine before it's installed.
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Priority: Minor
> Fix For: 0.1
>
> Attachments: perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-199) Integrate lib/perl into automake
Posted by "Carlos Valiente (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Valiente updated THRIFT-199:
-----------------------------------
Attachment: perl-automake-v2.diff
Thanks for the feedback, Esteve. I've added a simple test for MemoryBuffer.
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Priority: Minor
> Fix For: 0.1
>
> Attachments: perl-automake-v2.diff, perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (THRIFT-199) Integrate lib/perl into automake
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani reopened THRIFT-199:
-----------------------------------
Hey David,
Patch looks fine to me. Feel free to commit.
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-199.-perl-Let-make-distclean-work-when-we.patch, perl-automake-v2.diff, perl-automake-v3.diff, perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-199) Integrate lib/perl into automake
Posted by "Carlos Valiente (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Valiente updated THRIFT-199:
-----------------------------------
Attachment: perl-automake.diff
> Integrate lib/perl into automake
> --------------------------------
>
> Key: THRIFT-199
> URL: https://issues.apache.org/jira/browse/THRIFT-199
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Priority: Minor
> Fix For: 0.1
>
> Attachments: perl-automake.diff
>
>
> This patch adds lib/perl to the Automake build process, so that a 'make install' in the top level also installs the Perl modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.