You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "danielfernandez (via GitHub)" <gi...@apache.org> on 2023/08/18 10:08:35 UTC
[GitHub] [superset] danielfernandez opened a new issue, #25023: Issue adding a new DB spec: default_driver needs to have a non-empty value.
danielfernandez opened a new issue, #25023:
URL: https://github.com/apache/superset/issues/25023
Using Superset 2.1.0, I'm trying to add a new db spec and using `BasicParametersMixin` so that a form is shown at database creation time with all the parameters in separate inputs.
```python
class MyEngineSpec(BaseEngineSpec, BasicParametersMixin):
engine = "myengine"
engine_name = "My Engine"
default_driver = ""
sqlalchemy_uri_placeholder = (
"my://user:password@host:port/dbname[?key=value&key=value...]"
)
encryption_parameters = {"sslmode": "require"}
...
```
My SQL Alchemy dialect does **not** need the specification of a driver, and therefore I've set `default_driver` to the empty string. I've tried that and also `None`, but Superset will not show me the form corresponding with the `BasicParametersMixin` unless I set a non-empty value in `default_driver`... which is wrong and makes SQL Alchemy fail because my dialect does not need any driver names.
Is there any way I can work around this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on issue #25023: Issue adding a new DB spec: default_driver needs to have a non-empty value.
Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida commented on issue #25023:
URL: https://github.com/apache/superset/issues/25023#issuecomment-1718426103
I'm not sure I understand. What happens when you have `default_driver` set to an empty string? Can you share a screenshot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] danielfernandez commented on issue #25023: Issue adding a new DB spec: default_driver needs to have a non-empty value.
Posted by "danielfernandez (via GitHub)" <gi...@apache.org>.
danielfernandez commented on issue #25023:
URL: https://github.com/apache/superset/issues/25023#issuecomment-1718923387
What happens is that, for that data source, the `BasicParametersMixin` is ignored and no multi-input form --with separate server, port, user, password, etc. inputs-- is shown.
Instead, the standard SQL Alchemy URI form is shown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Issue adding a new DB spec: default_driver needs to have a non-empty value. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #25023: Issue adding a new DB spec: default_driver needs to have a non-empty value.
URL: https://github.com/apache/superset/issues/25023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Issue adding a new DB spec: default_driver needs to have a non-empty value. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25023:
URL: https://github.com/apache/superset/issues/25023#issuecomment-1992534120
Hi there, and sorry this has gone quiet for so long. We're no longer supporting Superset 2.x or prior, and it's been a while since this thread saw any activity, so I'm closing this as stale. If it is still an issue in Superset 3.x, we can re-open this, or feel free to open a new issue with updated context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org