[jira] [Closed] (THRIFT-4516) Add support for go 1.10

["James E. King III (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James E. King III closed THRIFT-4516.
-------------------------------------

> Add support for go 1.10
> -----------------------
>
>                 Key: THRIFT-4516
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4516
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Library
>    Affects Versions: 0.11.0
>         Environment: ubuntu-artful (using go 1.10 instead of 1.9)
>            Reporter: James E. King III
>            Assignee: Can Celasun
>            Priority: Major
>             Fix For: 0.12.0
>
>
> Currently go 1.10 has additional type checking on format strings that prevent thrift from compiling and running tests.  We are limited to go 1.9 until this is resolved.
> Example:
> {noformat}
> thrift/protocol_test.go:442: Errorf format %s has arg thelen of wrong type int
> thrift/protocol_test.go:447: Errorf format %q has arg v of wrong type float64
> thrift/protocol_test.go:451: Errorf format %q has arg v of wrong type float64
> thrift/protocol_test.go:454: Errorf format %q has arg value of wrong type float64
> thrift/protocol_test.go:482: Errorf format %s has arg thelen of wrong type int
> thrift/protocol_test.go:491: Errorf format %d has arg v of wrong type string
> gopath/src/dontexportrwtest/compile_test.go:32: Sprintf format %v arg s.read is a func value, not called
> gopath/src/dontexportrwtest/compile_test.go:33: Sprintf format %v arg s.write is a func value, not called
> gopath/src/dontexportrwtest/compile_test.go:36: Sprintf format %v arg is.read is a func value, not called
> gopath/src/dontexportrwtest/compile_test.go:37: Sprintf format %v arg is.write is a func value, not called{noformat}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)