You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/10/25 21:54:15 UTC

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2847: ISSUE #2846 Allow to run on java 17

eolivelli commented on a change in pull request #2847:
URL: https://github.com/apache/bookkeeper/pull/2847#discussion_r735994623



##########
File path: bin/bookkeeper
##########
@@ -148,6 +148,11 @@ LOGGING_OPTS=$(build_logging_opts ${BOOKIE_LOG_CONF} ${BOOKIE_LOG_DIR} ${BOOKIE_
 
 BOOKIE_EXTRA_OPTS="${BOOKIE_EXTRA_OPTS} -Dorg.bouncycastle.fips.approved_only=true"
 OPTS="${OPTS} -cp ${BOOKIE_CLASSPATH} ${BOOKIE_OPTS} ${GC_OPTS} ${NETTY_OPTS} ${LOGGING_OPTS} ${BOOKIE_EXTRA_OPTS}"
+VERSION_AUX=`java -version 2>&1|head -n 1|sed 's/"//g'|awk '{print $3}'|awk -F '.' '{print $1}'`

Review comment:
       Also, in this script we already have a utility function that checks if we are on jdk8
   
   In case of non jdk8 JVM you can add this additional option 
   
   BTW I second @merlimat 's suggestion




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org