You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "ywcb00 (via GitHub)" <gi...@apache.org> on 2026/09/04 14:52:10 UTC
[PR] [SYSTEMDS-3970] Obtain Nnz Information of Reads before Rewriting Main Program Block [systemds]
ywcb00 opened a new pull request, #2606:
URL: https://github.com/apache/systemds/pull/2606
Hi,
This PR adds the rewriting functionality to split a permanent read operation into a separate, preceding statement block if the meta data of the read object does not provide information about its number of non-zeros beforehand. By performing the read separately, the sparsity information can already be leveraged when recompiling the main program block.
The PR also adds a flag to disable and enable this new feature (disabled by default) as well as unit tests to cover the functionality.
All the best,
David
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3970] Obtain Nnz Information of Reads before Rewriting Main Program Block [systemds]
Posted by "ywcb00 (via GitHub)" <gi...@apache.org>.
ywcb00 closed pull request #2606: [SYSTEMDS-3970] Obtain Nnz Information of Reads before Rewriting Main Program Block
URL: https://github.com/apache/systemds/pull/2606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3970] Obtain Nnz Information of Reads before Rewriting Main Program Block [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2606:
URL: https://github.com/apache/systemds/pull/2606#issuecomment-5542697529
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2606?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `92.42424%` with `5 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 71.38%. Comparing base ([`0a245ab`](https://app.codecov.io/gh/apache/systemds/commit/0a245abd3d057ae674ec211f8793dc5ec5bf60c7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea7bbf7`](https://app.codecov.io/gh/apache/systemds/commit/ea7bbf72ff8183bb237c4cd7fac731e25764388f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/systemds/pull/2606?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ds/hops/rewrite/RewriteSplitDagUnknownNnzRead.java](https://app.codecov.io/gh/apache/systemds/pull/2606?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fhops%2Frewrite%2FRewriteSplitDagUnknownNnzRead.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL2hvcHMvcmV3cml0ZS9SZXdyaXRlU3BsaXREYWdVbmtub3duTm56UmVhZC5qYXZh) | 93.10% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/main/java/org/apache/sysds/hops/Hop.java](https://app.codecov.io/gh/apache/systemds/pull/2606?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fhops%2FHop.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL2hvcHMvSG9wLmphdmE=) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2606 +/- ##
============================================
- Coverage 71.39% 71.38% -0.02%
- Complexity 50539 50664 +125
============================================
Files 1632 1639 +7
Lines 196237 196864 +627
Branches 38201 38276 +75
============================================
+ Hits 140113 140541 +428
- Misses 45099 45259 +160
- Partials 11025 11064 +39
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/systemds/pull/2606?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org