You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mehul Parikh <me...@freestoneinfotech.com> on 2016/12/07 07:00:11 UTC
Review Request 54366: RANGER-1241 : PID file generation improvement
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54366/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-1241
https://issues.apache.org/jira/browse/RANGER-1241
Repository: ranger
Description
-------
Current logic of PID generation implemented in RANGER-1192 doesn't take care of a condition :: If variable of PID dir path is not set then use default value of PID dir.
Diffs
-----
tagsync/scripts/ranger-tagsync-services.sh 7f86e2f
unixauthservice/scripts/ranger-usersync-services.sh e5a676d
Diff: https://reviews.apache.org/r/54366/diff/
Testing
-------
Verified:
1) Manual install of Ranger with custom user / custom pid location.
2) Ambari based install of Ranger with custom user / custom pid location.
Thanks,
Mehul Parikh
Re: Review Request 54366: RANGER-1241 : PID file generation
improvement
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54366/#review158826
-----------------------------------------------------------
Ship it!
Ship It!
- Gautam Borad
On Dec. 7, 2016, 7 a.m., Mehul Parikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54366/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 7 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1241
> https://issues.apache.org/jira/browse/RANGER-1241
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Current logic of PID generation implemented in RANGER-1192 doesn't take care of a condition :: If variable of PID dir path is not set then use default value of PID dir.
>
>
> Diffs
> -----
>
> tagsync/scripts/ranger-tagsync-services.sh 7f86e2f
> unixauthservice/scripts/ranger-usersync-services.sh e5a676d
>
> Diff: https://reviews.apache.org/r/54366/diff/
>
>
> Testing
> -------
>
> Verified:
>
> 1) Manual install of Ranger with custom user / custom pid location.
> 2) Ambari based install of Ranger with custom user / custom pid location.
>
>
> Thanks,
>
> Mehul Parikh
>
>