You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Nitay Joffe <ni...@apache.org> on 2013/07/09 22:22:12 UTC
Re: Review Request 12322: GIRAPH-709: More flexible Jython script loading
(nitay)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12322/
-----------------------------------------------------------
(Updated July 9, 2013, 8:22 p.m.)
Review request for giraph.
Changes
-------
Avery's comments
Summary (updated)
-----------------
GIRAPH-709: More flexible Jython script loading (nitay)
Bugs: GIRAPH-709
https://issues.apache.org/jira/browse/GIRAPH-709
Repository: giraph-git
Description
-------
See JIRA.
Diffs (updated)
-----
giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java 413107dd70ba48ab7647127481ff47039fd1a758
giraph-core/src/main/java/org/apache/giraph/conf/JsonStringConfOption.java PRE-CREATION
giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java e81c7c491ac8d8c216cb229fab49489c2018853b
giraph-core/src/main/java/org/apache/giraph/jython/DeployType.java d91611902e78981dc0186322f7ab215c559dcff8
giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java b714e915aa34f3a8f746534642c5b8c4b0d85c57
giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java 77040e309e873fbc3394ae144176f10b95e85faa
giraph-core/src/main/java/org/apache/giraph/scripting/DeployType.java PRE-CREATION
giraph-core/src/main/java/org/apache/giraph/scripting/DeployedScript.java PRE-CREATION
giraph-core/src/main/java/org/apache/giraph/scripting/ScriptLoader.java PRE-CREATION
giraph-core/src/main/java/org/apache/giraph/scripting/package-info.java PRE-CREATION
giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 6b894038ef6768e5f1ed40b698828217bfa34668
giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java 58f25a67cdcf705f9cd845256ac6ebce8b4cc779
Diff: https://reviews.apache.org/r/12322/diff/
Testing
-------
Thanks,
Nitay Joffe
Re: Review Request 12322: GIRAPH-709: More flexible Jython script loading
(nitay)
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12322/#review22942
-----------------------------------------------------------
Ship it!
+1, looks good.
giraph-core/src/main/java/org/apache/giraph/conf/JsonStringConfOption.java
<https://reviews.apache.org/r/12322/#comment46727>
Redundant right?
giraph-core/src/main/java/org/apache/giraph/conf/JsonStringConfOption.java
<https://reviews.apache.org/r/12322/#comment46728>
Redundant right?
giraph-core/src/main/java/org/apache/giraph/conf/JsonStringConfOption.java
<https://reviews.apache.org/r/12322/#comment46729>
Redundant right?
- Avery Ching
On July 9, 2013, 8:22 p.m., Nitay Joffe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12322/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 8:22 p.m.)
>
>
> Review request for giraph.
>
>
> Bugs: GIRAPH-709
> https://issues.apache.org/jira/browse/GIRAPH-709
>
>
> Repository: giraph-git
>
>
> Description
> -------
>
> See JIRA.
>
>
> Diffs
> -----
>
> giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java 413107dd70ba48ab7647127481ff47039fd1a758
> giraph-core/src/main/java/org/apache/giraph/conf/JsonStringConfOption.java PRE-CREATION
> giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java e81c7c491ac8d8c216cb229fab49489c2018853b
> giraph-core/src/main/java/org/apache/giraph/jython/DeployType.java d91611902e78981dc0186322f7ab215c559dcff8
> giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java b714e915aa34f3a8f746534642c5b8c4b0d85c57
> giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java 77040e309e873fbc3394ae144176f10b95e85faa
> giraph-core/src/main/java/org/apache/giraph/scripting/DeployType.java PRE-CREATION
> giraph-core/src/main/java/org/apache/giraph/scripting/DeployedScript.java PRE-CREATION
> giraph-core/src/main/java/org/apache/giraph/scripting/ScriptLoader.java PRE-CREATION
> giraph-core/src/main/java/org/apache/giraph/scripting/package-info.java PRE-CREATION
> giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 6b894038ef6768e5f1ed40b698828217bfa34668
> giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java 58f25a67cdcf705f9cd845256ac6ebce8b4cc779
>
> Diff: https://reviews.apache.org/r/12322/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Nitay Joffe
>
>