You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/08/20 05:54:12 UTC

[kudu-CR] [fs] fix const-correctness of a few methods

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21693


Change subject: [fs] fix const-correctness of a few methods
......................................................................

[fs] fix const-correctness of a few methods

This patch doesn't contain any functional modifications.

Change-Id: I6f6cda8f33ad524097b33d238fd1e6d6fd9b2d3d
---
M src/kudu/fs/dir_manager.cc
M src/kudu/fs/dir_manager.h
M src/kudu/fs/dir_util.cc
M src/kudu/fs/dir_util.h
M src/kudu/fs/log_block_manager.cc
5 files changed, 12 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/21693/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f6cda8f33ad524097b33d238fd1e6d6fd9b2d3d
Gerrit-Change-Number: 21693
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [fs] fix const-correctness of a few methods

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21693 )

Change subject: [fs] fix const-correctness of a few methods
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f6cda8f33ad524097b33d238fd1e6d6fd9b2d3d
Gerrit-Change-Number: 21693
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 20 Aug 2024 07:29:07 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] fix const-correctness of a few methods

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21693 )

Change subject: [fs] fix const-correctness of a few methods
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f6cda8f33ad524097b33d238fd1e6d6fd9b2d3d
Gerrit-Change-Number: 21693
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 20 Aug 2024 06:12:25 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] fix const-correctness of a few methods

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21693 )

Change subject: [fs] fix const-correctness of a few methods
......................................................................

[fs] fix const-correctness of a few methods

This patch doesn't contain any functional modifications.

Change-Id: I6f6cda8f33ad524097b33d238fd1e6d6fd9b2d3d
Reviewed-on: http://gerrit.cloudera.org:8080/21693
Reviewed-by: Yingchun Lai <la...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/fs/dir_manager.cc
M src/kudu/fs/dir_manager.h
M src/kudu/fs/dir_util.cc
M src/kudu/fs/dir_util.h
M src/kudu/fs/log_block_manager.cc
5 files changed, 12 insertions(+), 11 deletions(-)

Approvals:
  Yingchun Lai: Looks good to me, approved
  Mahesh Reddy: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f6cda8f33ad524097b33d238fd1e6d6fd9b2d3d
Gerrit-Change-Number: 21693
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] [fs] fix const-correctness of a few methods

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21693 )

Change subject: [fs] fix const-correctness of a few methods
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/434/


-- 
To view, visit http://gerrit.cloudera.org:8080/21693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f6cda8f33ad524097b33d238fd1e6d6fd9b2d3d
Gerrit-Change-Number: 21693
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 20 Aug 2024 05:54:18 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] fix const-correctness of a few methods

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21693 )

Change subject: [fs] fix const-correctness of a few methods
......................................................................


Patch Set 1: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/434/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/21693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f6cda8f33ad524097b33d238fd1e6d6fd9b2d3d
Gerrit-Change-Number: 21693
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 20 Aug 2024 07:37:24 +0000
Gerrit-HasComments: No