You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/02/02 22:09:11 UTC
Re: Review Request 29606: Exposed authentication headers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29606/
-----------------------------------------------------------
(Updated Feb. 2, 2015, 4:09 p.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
rebased
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos
Description
-------
[8/9] Build Mesos Modules outside Mesos source tree.
This allows authentication modules to be built outside the mesos source tree.
Diffs (updated)
-----
src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e
src/authentication/authenticatee.hpp 361083b5e1ca5ab1a594b3108fb768626313a725
src/authentication/authenticator.hpp 460494a49ad7c71803507afe62005280d5929d41
src/authentication/cram_md5/authenticatee.hpp 5d35598f75f4d9a8c185cfd387e1085b3bf15395
src/authentication/cram_md5/authenticator.hpp d739a02d755c2729248291db8c274ad7e7dd4c6d
src/examples/test_authentication_modules.cpp 6d32573d4e7817ddb62f3eb7aca2cf3f06d27c65
src/master/master.hpp 337e00aa46ea127f3667e3383d631c3fb8e22f30
src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323
src/module/authenticatee.hpp bae37ced0b5da5dec2ff91d795cc8e75fd8900f2
src/module/authenticator.hpp 956233852c355f67b890479b7330d2d2f01dbaf3
src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2
src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268
src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b
src/tests/cram_md5_authentication_tests.cpp a356aa1fbcf5492b22e78bd4e7ee1d092f5cf736
Diff: https://reviews.apache.org/r/29606/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 29606: Exposed authentication headers.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29606/
-----------------------------------------------------------
(Updated Feb. 9, 2015, 9:39 p.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
moved headers to their own directory.
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos
Description
-------
[8/9] Build Mesos Modules outside Mesos source tree.
This allows authentication modules to be built outside the mesos source tree.
Diffs (updated)
-----
src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc
src/authentication/authenticatee.hpp 95798d74d256539fac5624c106e0f9285d107f13
src/authentication/authenticator.hpp abc2a2398265f3b37449a3c9f5bb3d1f2b7fdc96
src/authentication/cram_md5/authenticatee.hpp 70e150934c79d5ccf9aa23cdc3a10f6f986eba0d
src/authentication/cram_md5/authenticator.hpp fa34f7654b0c3e3cd7139baaf729c1045b1f774a
src/examples/test_authentication_modules.cpp fd59fe47201a2f1b153e811a57ae33b590473b3a
src/master/master.hpp c3c77f840f089c5754c764e7f150a3c1971d311f
src/master/master.cpp 22fece79c6e511a1b61eb674d7f82216e7a25e00
src/module/authenticatee.hpp a53016a7a24dfe37998eb6b0d886b7096760ae49
src/module/authenticator.hpp 156617ba5ca3ca3d38f3ff19a74ccfe26fc77008
src/sched/sched.cpp ce6ff6d9adeebf398a7921421062dd5623052af1
src/scheduler/scheduler.cpp f5ee1b04cbc9f5fafead8a3b44769ae7d2f3487e
src/slave/slave.hpp 9adee17cb94a72f0e1e139b3fd8978a9a1ff6237
src/slave/slave.cpp 336e8776be656c5e6ad1b0d997f54c307f4559f8
src/tests/cram_md5_authentication_tests.cpp 8b50413545858e92790119a3d4467fdedec00d45
Diff: https://reviews.apache.org/r/29606/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 29606: Exposed authentication headers.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29606/#review71733
-----------------------------------------------------------
Ship it!
src/Makefile.am
<https://reviews.apache.org/r/29606/#comment117600>
How about moving these to their own directory? similiary to the isolator include?
- Niklas Nielsen
On Feb. 4, 2015, 7:16 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29606/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 7:16 p.m.)
>
>
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-2096
> https://issues.apache.org/jira/browse/MESOS-2096
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [8/9] Build Mesos Modules outside Mesos source tree.
>
> This allows authentication modules to be built outside the mesos source tree.
>
>
> Diffs
> -----
>
> src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc
> src/authentication/authenticatee.hpp 361083b5e1ca5ab1a594b3108fb768626313a725
> src/authentication/authenticator.hpp 460494a49ad7c71803507afe62005280d5929d41
> src/authentication/cram_md5/authenticatee.hpp 5d35598f75f4d9a8c185cfd387e1085b3bf15395
> src/authentication/cram_md5/authenticator.hpp d739a02d755c2729248291db8c274ad7e7dd4c6d
> src/examples/test_authentication_modules.cpp 6d32573d4e7817ddb62f3eb7aca2cf3f06d27c65
> src/master/master.hpp dcfd38ae2fa9e1bd0b477e9719724dba37114d30
> src/master/master.cpp 234bbecc4205036d790b026abd59100eb188f913
> src/module/authenticatee.hpp bae37ced0b5da5dec2ff91d795cc8e75fd8900f2
> src/module/authenticator.hpp 956233852c355f67b890479b7330d2d2f01dbaf3
> src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2
> src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268
> src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
> src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b
> src/tests/cram_md5_authentication_tests.cpp a356aa1fbcf5492b22e78bd4e7ee1d092f5cf736
>
> Diff: https://reviews.apache.org/r/29606/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29606: Exposed authentication headers.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29606/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 10:16 p.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
rebased
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos
Description
-------
[8/9] Build Mesos Modules outside Mesos source tree.
This allows authentication modules to be built outside the mesos source tree.
Diffs (updated)
-----
src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc
src/authentication/authenticatee.hpp 361083b5e1ca5ab1a594b3108fb768626313a725
src/authentication/authenticator.hpp 460494a49ad7c71803507afe62005280d5929d41
src/authentication/cram_md5/authenticatee.hpp 5d35598f75f4d9a8c185cfd387e1085b3bf15395
src/authentication/cram_md5/authenticator.hpp d739a02d755c2729248291db8c274ad7e7dd4c6d
src/examples/test_authentication_modules.cpp 6d32573d4e7817ddb62f3eb7aca2cf3f06d27c65
src/master/master.hpp dcfd38ae2fa9e1bd0b477e9719724dba37114d30
src/master/master.cpp 234bbecc4205036d790b026abd59100eb188f913
src/module/authenticatee.hpp bae37ced0b5da5dec2ff91d795cc8e75fd8900f2
src/module/authenticator.hpp 956233852c355f67b890479b7330d2d2f01dbaf3
src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2
src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268
src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b
src/tests/cram_md5_authentication_tests.cpp a356aa1fbcf5492b22e78bd4e7ee1d092f5cf736
Diff: https://reviews.apache.org/r/29606/diff/
Testing
-------
make check
Thanks,
Kapil Arya