You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/20 06:33:02 UTC

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9853: Adding Emotion ThemeProviders for all React apps

rusackas commented on a change in pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#discussion_r427771002



##########
File path: superset-frontend/src/explore/App.jsx
##########
@@ -32,10 +34,12 @@ setupPlugins();
 
 const App = ({ store }) => (
   <Provider store={store}>
-    <div>
-      <ExploreViewContainer />
-      <ToastPresenter />
-    </div>
+    <ThemeProvider theme={supersetTheme}>
+      <div>

Review comment:
       This div doesn't look like it has any business being here, but I don't want to be wrong when it's beside the point of this PR ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org