You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "NingleXu (via GitHub)" <gi...@apache.org> on 2023/09/15 08:57:19 UTC
[GitHub] [dubbo] NingleXu opened a new pull request, #13061: Add volatile on destroyed filed ensure visibility
NingleXu opened a new pull request, #13061:
URL: https://github.com/apache/dubbo/pull/13061
## What is the purpose of the change
## Brief changelog
为AbstractInvoker的destroyed字段添加volatile关键字,确保多线程的可见性。
#13060
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #13061: Add volatile on destroyed filed ensure visibility
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ merged PR #13061:
URL: https://github.com/apache/dubbo/pull/13061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13061: Add volatile on destroyed filed ensure visibility
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13061:
URL: https://github.com/apache/dubbo/pull/13061#issuecomment-1724798438
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13061)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13061&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13061&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13061&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13061&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13061&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13061&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13061&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13061&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13061&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13061&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13061&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13061&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13061&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13061&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13061&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13061&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] imhuzi commented on pull request #13061: Add volatile on destroyed filed ensure visibility
Posted by "imhuzi (via GitHub)" <gi...@apache.org>.
imhuzi commented on PR #13061:
URL: https://github.com/apache/dubbo/pull/13061#issuecomment-1721031409
退订
On Fri, Sep 15, 2023 at 16:57 xuziheng ***@***.***> wrote:
> What is the purpose of the change Brief changelog
>
> 为AbstractInvoker的destroyed字段添加volatile关键字,确保多线程的可见性。
> #13060 <https://github.com/apache/dubbo/issues/13060>
> Verifying this change Checklist
>
> - Make sure there is a GitHub_issue
> <https://github.com/apache/dubbo/issues> field for the change (usually
> before you start working on it). Trivial changes like typos do not require
> a GitHub issue. Your pull request should address just this issue, without
> pulling in other changes - one PR resolves one issue.
> - Each commit in the pull request should have a meaningful subject
> line and body.
> - Write a pull request description that is detailed enough to
> understand what the pull request does, how, and why.
> - Check if is necessary to patch to Dubbo 3 if you are work on Dubbo
> 2.7
> - Write necessary unit-test to verify your logic correction, more mock
> a little better when cross module dependency exist. If the new feature or
> significant change is committed, please remember to add sample in dubbo
> samples <https://github.com/apache/dubbo-samples> project.
> - Add some description to dubbo-website
> <https://github.com/apache/dubbo-website> project if you are
> requesting to add a feature.
> - GitHub Actions works fine on your own branch.
> - If this contribution is large, please follow the Software Donation
> Guide <https://github.com/apache/dubbo/wiki/Software-donation-guide>.
>
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/dubbo/pull/13061
> Commit Summary
>
> - f8ebfba
> <https://github.com/apache/dubbo/pull/13061/commits/f8ebfba41fc79258495aad1153d177399d87f019>
> Add volatile on destroyed filed ensure visibility
>
> File Changes
>
> (1 file <https://github.com/apache/dubbo/pull/13061/files>)
>
> - *M*
> dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/AbstractInvoker.java
> <https://github.com/apache/dubbo/pull/13061/files#diff-4681821b7f6b122431213007f59379e294c5fd0394794d435397f79cb4f2f84c>
> (2)
>
> Patch Links:
>
> - https://github.com/apache/dubbo/pull/13061.patch
> - https://github.com/apache/dubbo/pull/13061.diff
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/dubbo/pull/13061>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAF74AOBQV6ZRNH42JGETT3X2QKALANCNFSM6AAAAAA4ZPRTBI>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #13061: Add volatile on destroyed filed ensure visibility
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #13061:
URL: https://github.com/apache/dubbo/pull/13061#issuecomment-1724800667
## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/13061?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#13061](https://app.codecov.io/gh/apache/dubbo/pull/13061?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (939492f) into [3.2](https://app.codecov.io/gh/apache/dubbo/commit/139a62ebb953bbef3cf46d9e9358f81947acc1f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (139a62e) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.2 #13061 +/- ##
============================================
- Coverage 69.43% 69.37% -0.06%
Complexity 2 2
============================================
Files 1649 1649
Lines 68566 68566
Branches 10001 10001
============================================
- Hits 47607 47570 -37
- Misses 16368 16410 +42
+ Partials 4591 4586 -5
```
[see 33 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo/pull/13061/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org