You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 10:36:26 UTC

[GitHub] [flink] zhuzhurk opened a new pull request #12223: [FLINK-15813][runtime] Set default value of config “jobmanager.execution.failover-strategy” to “region”

zhuzhurk opened a new pull request #12223:
URL: https://github.com/apache/flink/pull/12223


   ## What is the purpose of the change
   
   This PR is to set the default value of jobmanager.execution.failover-strategy to region.
   The DefaultScheduler now already uses "region" as the default value so it does not cause any behavior change in production.
   
   ## Brief change log
   
   See commits.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *FailoverStrategyFactoryLoaderTest*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk merged pull request #12223: [FLINK-15813][runtime] Set default value of config “jobmanager.execution.failover-strategy” to “region”

Posted by GitBox <gi...@apache.org>.

zhuzhurk merged pull request #12223:
URL: https://github.com/apache/flink/pull/12223


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12223: [FLINK-15813][runtime] Set default value of config “jobmanager.execution.failover-strategy” to “region”

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12223:
URL: https://github.com/apache/flink/pull/12223#issuecomment-630123802


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1984222ee161599a34d41ba2d8dc6466b4858fab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1984222ee161599a34d41ba2d8dc6466b4858fab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1984222ee161599a34d41ba2d8dc6466b4858fab UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12223: [FLINK-15813][runtime] Set default value of config “jobmanager.execution.failover-strategy” to “region”

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12223:
URL: https://github.com/apache/flink/pull/12223#issuecomment-630109130

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit ca8117ccc6771dcba2fc7013be27c362c14bfbfb (Mon May 18 11:04:01 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12223: [FLINK-15813][runtime] Set default value of config “jobmanager.execution.failover-strategy” to “region”

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12223:
URL: https://github.com/apache/flink/pull/12223#issuecomment-630109130

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 1984222ee161599a34d41ba2d8dc6466b4858fab (Fri Oct 16 10:49:14 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12223: [FLINK-15813][runtime] Set default value of config “jobmanager.execution.failover-strategy” to “region”

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12223:
URL: https://github.com/apache/flink/pull/12223#issuecomment-630123802


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1984222ee161599a34d41ba2d8dc6466b4858fab",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1728",
       "triggerID" : "1984222ee161599a34d41ba2d8dc6466b4858fab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1984222ee161599a34d41ba2d8dc6466b4858fab Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1728) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12223: [FLINK-15813][runtime] Set default value of config “jobmanager.execution.failover-strategy” to “region”

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12223:
URL: https://github.com/apache/flink/pull/12223#issuecomment-630123802


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1984222ee161599a34d41ba2d8dc6466b4858fab",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1728",
       "triggerID" : "1984222ee161599a34d41ba2d8dc6466b4858fab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1984222ee161599a34d41ba2d8dc6466b4858fab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1728) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org