[GitHub] [kafka] cadonna commented on a diff in pull request #12569: KAFKA-10199: Shutdown state updater on task manager shutdown

[GitBox <gi...@apache.org>]

cadonna commented on code in PR #12569:
URL: https://github.com/apache/kafka/pull/12569#discussion_r959907923


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -1180,6 +1182,68 @@ void shutdown(final boolean clean) {
         }
     }
 
+    private void shutdownStateUpdater() {
+        if (stateUpdater != null) {
+            stateUpdater.shutdown(Duration.ofMillis(Long.MAX_VALUE));
+            closeFailedTasks();
+            addRestoredTasksToTaskRegistry();
+            addRemovedTasksToTaskRegistry();
+        }
+    }
+
+    private void closeFailedTasks() {

Review Comment:
   I will do the renaming in the next PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org