[jira] [Commented] (OAK-3477) Make JMX Bean names predictable so they can be used in configurations.

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010549#comment-15010549 ] 

Michael Dürig commented on OAK-3477:
------------------------------------

Looks good I think. Do we know what the consequences are when we happen to run into a name conflict? The impact should be contained within monitoring and not affect overall system stability. Maybe we could do some validation around this. 

Alternatively we could try to detect a name conflict and re-register in such a case with disambiguation. Not sure it its worth the extra trouble though. 

> Make JMX Bean names predictable so they can be used in configurations.
> ----------------------------------------------------------------------
>
>                 Key: OAK-3477
>                 URL: https://issues.apache.org/jira/browse/OAK-3477
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.3.7
>            Reporter: Ian Boston
>            Assignee: Chetan Mehrotra
>              Labels: candidate_oak_1_0, candidate_oak_1_2
>             Fix For: 1.3.11
>
>         Attachments: OAK-3477.patch
>
>
> In Oak there are JMX beans which get names of the form [1], which can be hard to use in monitoring tool configuration that dont support regexes as the ID will change.  Where possible, the ID should be removed or made static. The name and type should be sufficient in most cases in Oak to make the JMX Object name unique.
> 1
> {code}
> org.apache.jackrabbit.oak:name="Consolidated Cache
> statistics",type="ConsolidatedCacheStats",id=6
> org.apache.jackrabbit.oak:name="CopyOnRead support
> statistics",type="CopyOnReadStats",id=7
> org.apache.jackrabbit.oak:name="Oak Repository
> Statistics",type="RepositoryStats",id=16
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)