[GitHub] liubao68 commented on a change in pull request #755: [SCB-649] when port can't been listened, log warn and show more detail message

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #755: [SCB-649] when port can't been listened,log warn and show more detail message
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/755#discussion_r193708272
 
 

 ##########
 File path: transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/VertxRestTransport.java
 ##########
 @@ -59,7 +59,7 @@ public boolean canInit() {
     }
 
     if (!NetUtils.canTcpListen(ep.getSocketAddress().getAddress(), ep.getPort())) {
-      log.info("can not listen {}, skip {}.", ep.getSocketAddress(), this.getClass().getName());
+      log.warn("can not listen {}, port may have been occupied, this may cause client report error when being accessed. skip {}.", ep.getSocketAddress(), this.getClass().getName());
 
 Review comment:
   We can't detect if the started port is tomcat, so in this scenario(port started by another service, and the dependency contains both transport-rest-servlet and transport-rest-vertx) will cause problem. May the warning message can be changed as: 
   WARNING: Can not start VertxRestTransport, the port may have been occupied. You can ignore this message if you are using a web container like tomcat. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services