[jira] [Updated] (OAK-6450) Stop relying on the service.pid property in SecurityProviderRegistration

["Robert Munteanu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Munteanu updated OAK-6450:
---------------------------------
    Attachment: 0001-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch

I've uploaded a patch

[~anchela], [~chetanm], [~frm], [~reschke] - would appreciate your feedback based on the discussion from OAK-6111 . I successfully ran a {mvn clean install -Ppedantic} build with these changes and the maven-scr-plugin version set to 1.24.0

To quote the commit message:

{noformat}Use the comoponent.name component property if the service.pid
is not available. The SecurityProviderRegistration property name is
unchanged, for backwards compatibility reasons.

The objectClass property may not be used as it points to the service
name(s) under which the component is registered. Using a custom property
name such as oak.security.name was considered but discarded as:

* all services would need to set this service property
* the component.name property is guaranteed to be added by the SCR
implementation, according to the OSGi Declarative Services spec 1.3 (
see OSGi Compendium R6, section 112.6 - Component Properties ){noformat}

I intend to go ahead with OAK-6449 once this is fixed.



> Stop relying on the service.pid property in SecurityProviderRegistration
> ------------------------------------------------------------------------
>
>                 Key: OAK-6450
>                 URL: https://issues.apache.org/jira/browse/OAK-6450
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: security
>            Reporter: Robert Munteanu
>            Assignee: Robert Munteanu
>             Fix For: 1.8, 1.7.4
>
>         Attachments: 0001-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch
>
>
> As discussed in OAK-6111, we should stop relying on the {{service.pid}} OSGi property for tracking required services as it was incorrectly set so far by the {{maven-scr-plugin}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)