You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Tal Daniel <ta...@gmail.com> on 2014/04/07 14:07:48 UTC
[www] [PATCH] index.html
Can any Committer take responsibility to commit the attached patch? (it's
my first patch :). I removed a missing reference to product.css from the
<head> section.
Thanks,
Tal
Re: [www] [PATCH] index.html
Posted by "Marcus (OOo)" <ma...@wtnet.de>.
Am 04/10/2014 12:51 AM, schrieb Tal Daniel:
> Just a thanks to Marcus (and Andrea, for confusing me with the Math :)
You are welcome.
If there some more things, just let us know.
Marcus
> On Thu, Apr 10, 2014 at 12:09 AM, Marcus (OOo) <marcus.mail@wtnet.de
> <ma...@wtnet.de>> wrote:
>
> Am 04/07/2014 02:07 PM, schrieb Tal Daniel:
>
> Can any Committer take responsibility to commit the attached patch?
> (it's my first patch :). I removed a missing reference to
> product.css
> from the <head> section.
>
>
> Thanks for this. I've committed your change.
>
> Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [www] [PATCH] index.html
Posted by "Marcus (OOo)" <ma...@wtnet.de>.
Am 04/07/2014 02:07 PM, schrieb Tal Daniel:
> Can any Committer take responsibility to commit the attached patch?
> (it's my first patch :). I removed a missing reference to product.css
> from the <head> section.
Thanks for this. I've committed your change.
Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [www] [PATCH] index.html
Posted by "Marcus (OOo)" <ma...@wtnet.de>.
Am 04/08/2014 11:04 PM, schrieb Andrea Pescetti:
> Marcus (OOo) wrote:
>> The current code line is:
>> <link rel="STYLESHEET" type="text/css" href="/product/product.css"
>> media="screen" />
>> ... This CSS file doesn't exist
>
> It was removed 2 years ago, when the entire Product section was rewritten:
> http://svn.apache.org/viewvc?view=revision&revision=r1347603
>
>> However, currently it doesn't change anything if the line is there or
>> not. Therefore it can be deleted anyway.
>
> Sure. And actually deleting it is an improvement, since currently all
> homepage visits generate an error in the logs and in the browser
> console, and we serve a custom 404 (with all JavaScript and text) to the
> browser instead of the requested file, thus wasting bandwidth (8 KB, a
> tiny fraction of the combined page size, but at one million visits per
> day it's still 8 GB!).
Interesting math ;-) - and of course convincing.
I've searched a bit and found some more locations that I've fixed, too.
However, it's possible that there are some more as I've not checked-out
the entire OpenOffice website.
Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [www] [PATCH] index.html
Posted by Andrea Pescetti <pe...@apache.org>.
Marcus (OOo) wrote:
> The current code line is:
> <link rel="STYLESHEET" type="text/css" href="/product/product.css"
> media="screen" />
> ... This CSS file doesn't exist
It was removed 2 years ago, when the entire Product section was rewritten:
http://svn.apache.org/viewvc?view=revision&revision=r1347603
> However, currently it doesn't change anything if the line is there or
> not. Therefore it can be deleted anyway.
Sure. And actually deleting it is an improvement, since currently all
homepage visits generate an error in the logs and in the browser
console, and we serve a custom 404 (with all JavaScript and text) to the
browser instead of the requested file, thus wasting bandwidth (8 KB, a
tiny fraction of the combined page size, but at one million visits per
day it's still 8 GB!).
Regards,
Andrea.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [www] [PATCH] index.html
Posted by "Marcus (OOo)" <ma...@wtnet.de>.
Am 04/08/2014 09:40 PM, schrieb Rob Weir:
> On Tue, Apr 8, 2014 at 1:33 PM, Marcus (OOo)<ma...@wtnet.de> wrote:
>> Am 04/08/2014 09:17 PM, schrieb Rob Weir:
>>
>>> On Mon, Apr 7, 2014 at 12:30 PM, Marcus (OOo)<ma...@wtnet.de>
>>> wrote:
>>>>
>>>> Am 04/07/2014 02:07 PM, schrieb Tal Daniel:
>>>>
>>>>> Can any Committer take responsibility to commit the attached patch?
>>>>> (it's my first patch :). I removed a missing reference to product.css
>>>>> from the<head> section.
>>>>
>>>>
>>>>
>>>> @Rob:
>>>> I remember that you have added some meta data long time ago. Do you
>>>> remember
>>>> this certain meta data?
>>>>
>>>
>>> Yes, we should keep those.
>>>
>>> -Rob
>>>
>>>> "/product/product.css" doesn't exist, so of course it doesn't have any
>>>> bad
>>>> effects when deleting the line.
>>
>>
>> do you have an idea how to change this, that it is working again?
>>
>
> To make what working again?
The current code line is:
<link rel="STYLESHEET" type="text/css" href="/product/product.css"
media="screen" />
That means the browser should use explicit "/product/product.css" when
the webpage should be shown on a PC screen (not printer or other
possibilities [1]).
This CSS file doesn't exist:
$ svn log product/product.css
svn: 'product/product.css' is not under version control
> Did something change?
I don't know if this was ever working.
However, currently it doesn't change anything if the line is there or
not. Therefore it can be deleted anyway.
Furthermore, I don't think that we want to use different CSS files for
presenting the website on a screen or when printing or handheld or ...
[1] http://www.w3.org/TR/html401/types.html#type-media-descriptors
Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [www] [PATCH] index.html
Posted by Rob Weir <ro...@apache.org>.
On Tue, Apr 8, 2014 at 1:33 PM, Marcus (OOo) <ma...@wtnet.de> wrote:
> Am 04/08/2014 09:17 PM, schrieb Rob Weir:
>
>> On Mon, Apr 7, 2014 at 12:30 PM, Marcus (OOo)<ma...@wtnet.de>
>> wrote:
>>>
>>> Am 04/07/2014 02:07 PM, schrieb Tal Daniel:
>>>
>>>> Can any Committer take responsibility to commit the attached patch?
>>>> (it's my first patch :). I removed a missing reference to product.css
>>>> from the<head> section.
>>>
>>>
>>>
>>> @Rob:
>>> I remember that you have added some meta data long time ago. Do you
>>> remember
>>> this certain meta data?
>>>
>>
>> Yes, we should keep those.
>>
>> -Rob
>>
>>> "/product/product.css" doesn't exist, so of course it doesn't have any
>>> bad
>>> effects when deleting the line.
>
>
> do you have an idea how to change this, that it is working again?
>
To make what working again? Did something change?
-Rob
> Thanks
>
> Marcus
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [www] [PATCH] index.html
Posted by "Marcus (OOo)" <ma...@wtnet.de>.
Am 04/08/2014 09:17 PM, schrieb Rob Weir:
> On Mon, Apr 7, 2014 at 12:30 PM, Marcus (OOo)<ma...@wtnet.de> wrote:
>> Am 04/07/2014 02:07 PM, schrieb Tal Daniel:
>>
>>> Can any Committer take responsibility to commit the attached patch?
>>> (it's my first patch :). I removed a missing reference to product.css
>>> from the<head> section.
>>
>>
>> @Rob:
>> I remember that you have added some meta data long time ago. Do you remember
>> this certain meta data?
>>
>
> Yes, we should keep those.
>
> -Rob
>
>> "/product/product.css" doesn't exist, so of course it doesn't have any bad
>> effects when deleting the line.
do you have an idea how to change this, that it is working again?
Thanks
Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [www] [PATCH] index.html
Posted by Rob Weir <ro...@apache.org>.
On Mon, Apr 7, 2014 at 12:30 PM, Marcus (OOo) <ma...@wtnet.de> wrote:
> Am 04/07/2014 02:07 PM, schrieb Tal Daniel:
>
>> Can any Committer take responsibility to commit the attached patch?
>> (it's my first patch :). I removed a missing reference to product.css
>> from the <head> section.
>
>
> @Rob:
> I remember that you have added some meta data long time ago. Do you remember
> this certain meta data?
>
Yes, we should keep those.
-Rob
> "/product/product.css" doesn't exist, so of course it doesn't have any bad
> effects when deleting the line.
>
> Thanks
>
> Marcus
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [www] [PATCH] index.html
Posted by "Marcus (OOo)" <ma...@wtnet.de>.
Am 04/07/2014 02:07 PM, schrieb Tal Daniel:
> Can any Committer take responsibility to commit the attached patch?
> (it's my first patch :). I removed a missing reference to product.css
> from the <head> section.
@Rob:
I remember that you have added some meta data long time ago. Do you
remember this certain meta data?
"/product/product.css" doesn't exist, so of course it doesn't have any
bad effects when deleting the line.
Thanks
Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org