You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/09/21 11:02:23 UTC
[GitHub] [lucene] ChrisHegarty opened a new pull request #314: LUCENE-10115: Add an extension point for custom query parsers to determine the similarity distance for fuzzy queries
ChrisHegarty opened a new pull request #314:
URL: https://github.com/apache/lucene/pull/314
# Description
Add an extension point for custom query parsers to determine the similarity distance for fuzzy queries. This will be used by the elasticsearch query parser to customise how similarity distances are determined.
# Solution
This PR adds the `QueryParserBase::getFuzzyDistance` protected method, which can be overridden by subclasses to provide customisation of how the similarity distance is determined. The default implementation behaves as the current, before-this-change, behaviour.
# Tests
An additional test scenarios, testFuzzyDistanceExtendability, has been added that exercises the default functionality, as well as how a custom implementation could behave.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] ChrisHegarty commented on pull request #314: LUCENE-10115: Add an extension point for custom query parsers to determine the similarity distance for fuzzy queries
Posted by GitBox <gi...@apache.org>.
ChrisHegarty commented on pull request #314:
URL: https://github.com/apache/lucene/pull/314#issuecomment-923895124
> Can you add an entry to `lucene/CHANGES.txt` for version 9.0?
@jpountz Yes, I will add an entry to the "API Changes" section and update this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] romseygeek merged pull request #314: LUCENE-10115: Add an extension point for custom query parsers to determine the similarity distance for fuzzy queries
Posted by GitBox <gi...@apache.org>.
romseygeek merged pull request #314:
URL: https://github.com/apache/lucene/pull/314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org