You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/01 22:29:13 UTC

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20115: [CD] Tag "release" to pip wheels in CD

leezu commented on a change in pull request #20115:
URL: https://github.com/apache/incubator-mxnet/pull/20115#discussion_r605979848



##########
File path: tools/pip/setup.py
##########
@@ -58,6 +58,10 @@
 elif travis_tag.startswith('patch-'):
     __version__ = os.environ['TRAVIS_TAG'].split('-')[1]
 
+# release tag
+elif is_release:
+    __version__ += 'RELEASE'

Review comment:
       "mxnet-2.0.0RELEASE-py3-none-manylinux2014_x86_64.whl" may not be the correct naming scheme for uploading to Pypi. Also if we install mxnet from pypi and call `mxnet.__version__`, seeing `2.0.0.alphaRELEASE` may be unexpected. Do you think we should generate the wheels to be ready for upload?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org