[GitHub] [airflow] potiuk commented on pull request #22740: Switch to `pipx` as the only installation Breeze2 method

[GitBox <gi...@apache.org>]

potiuk commented on PR #22740:
URL: https://github.com/apache/airflow/pull/22740#issuecomment-1088052284

   Hey @uranusjr - it's about the time we switch to the new Breeze and after trying various behaviours, I think the idea of only using `pipx` for installation that you advoceated for is the best (with a few caveats).
   
   I described the caveats in ADR 10 (see the PR)  with some description of what I think is needed in order to get `pipx-only' installation works for us. I implemented in the PR all the features but I need your help in the last one.
   
   The features I implemented:
   
   1) fail if Breeze is installed in non-editable mode. This was easy and needed, this way we prevent users from mistakenly install breeze without editable mode and will make sure they are not using outdated pipx if we the sources change on checkout
   
   2) warn (and add small delay) if we detect if Breeze runs in another "airflow" source tree - this is needed because the version/deps of Breeze in that source tree might be different and we might need the different version in the source tree. But this is just a warning and we allow Breeze to work in the other source tree  as **most likely** it will work - and it will nicely handle the case when user has mutliple airflow source dirs without having to reinstall breeze
   
   Now - I need your help in the third case::
   
   3) I need to find out if the setup.py/cfg changed since the last installation and also warn the user. Not having some deps installed in the future might be source of confusion with cryptic errors, so I would like to detect the situation and continue runnign but warn the user (with little timeout). I almost have it - the only thing I need is to save the setup.py/cfg files in a cache **right** after installation. Since we are always running in "editable" mode, there used to be a way to run "develop" after installation. I think though it has changed wiht newer `pip` versiosn (on the road to pyproject.toml). Is there a way to achieve it in a "portable" and PEP 660 - compliant way?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org