[jira] [Work logged] (HIVE-26573) ClassCastException error on window function

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-26573?focusedWorklogId=813074&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813074 ]

ASF GitHub Bot logged work on HIVE-26573:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Sep/22 17:42
            Start Date: 28/Sep/22 17:42
    Worklog Time Spent: 10m 
      Work Description: scarlin-cloudera opened a new pull request, #3630:
URL: https://github.com/apache/hive/pull/3630

   A ClassCastException error was being thrown while deserializing a Decimal64Vector.
   
   It is unnecessary for the code to check the DataTypePhysicalVariation property within VectorDeserializeRow.  There is already enough information to determine that the binding should bedone with the Decimal64Vector. So the code now just checks for the instance when deciding on the binding.
   
   Another bug was found while implementing this fix. The Lazy reads were always converting the decimal into its decimal64 form which isn't necessary when there is no decimal64 binding. This code is now pushed into VectorDeserializeRow which is the only place in the repository which references this variable.
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   See commit description
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   See commit description
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Unit test added
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 813074)
    Remaining Estimate: 0h
            Time Spent: 10m

> ClassCastException error on window function
> -------------------------------------------
>
>                 Key: HIVE-26573
>                 URL: https://issues.apache.org/jira/browse/HIVE-26573
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>            Reporter: Steve Carlin
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The following query from the tpcds dataset is throwing an exception:
> select 
>    SUM (i_current_price)
>   OVER (ORDER BY i_item_sk) running_total
> from item
> limit 10
> with the error
> E   Caused by: java.lang.ClassCastException: org.apache.hadoop.hive.ql.exec.vector.Decimal64ColumnVector cannot be cast to org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector



--
This message was sent by Atlassian Jira
(v8.20.10#820010)