You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by GitBox <gi...@apache.org> on 2020/05/24 17:37:45 UTC
[GitHub] [aries-jax-rs-whiteboard] rotty3000 opened a new pull request #27: auto close client builders
rotty3000 opened a new pull request #27:
URL: https://github.com/apache/aries-jax-rs-whiteboard/pull/27
Signed-off-by: Raymond Auge <ro...@apache.org>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [aries-jax-rs-whiteboard] rotty3000 commented on pull request #27: auto close client builders
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #27:
URL: https://github.com/apache/aries-jax-rs-whiteboard/pull/27#issuecomment-669289342
perhaps it would be wise to start with a test that confirms clients are un-closed (and not GC'd, i.e. memory leak)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [aries-jax-rs-whiteboard] rotty3000 commented on pull request #27: auto close client builders
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #27:
URL: https://github.com/apache/aries-jax-rs-whiteboard/pull/27#issuecomment-633265145
What do you think about this change @csierra ? Does it make sense to close the builders? I fear the underlying impls might be leaking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [aries-jax-rs-whiteboard] rotty3000 closed pull request #27: auto close client builders
Posted by GitBox <gi...@apache.org>.
rotty3000 closed pull request #27:
URL: https://github.com/apache/aries-jax-rs-whiteboard/pull/27
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [aries-jax-rs-whiteboard] rotty3000 commented on pull request #27: auto close client builders
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #27:
URL: https://github.com/apache/aries-jax-rs-whiteboard/pull/27#issuecomment-669285523
that sounds reasonable! I will try to update this in the coming weeks. There isn't a rush for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [aries-jax-rs-whiteboard] rotty3000 closed pull request #27: auto close client builders
Posted by GitBox <gi...@apache.org>.
rotty3000 closed pull request #27:
URL: https://github.com/apache/aries-jax-rs-whiteboard/pull/27
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [aries-jax-rs-whiteboard] csierra commented on pull request #27: auto close client builders
Posted by GitBox <gi...@apache.org>.
csierra commented on pull request #27:
URL: https://github.com/apache/aries-jax-rs-whiteboard/pull/27#issuecomment-669286870
because if that's the case I guess our only chance is to use a reference queue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [aries-jax-rs-whiteboard] rotty3000 commented on pull request #27: auto close client builders
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #27:
URL: https://github.com/apache/aries-jax-rs-whiteboard/pull/27#issuecomment-633265243
I should be able to write a test that proves this one way or the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [aries-jax-rs-whiteboard] csierra commented on pull request #27: auto close client builders
Posted by GitBox <gi...@apache.org>.
csierra commented on pull request #27:
URL: https://github.com/apache/aries-jax-rs-whiteboard/pull/27#issuecomment-669286567
do you think we should keep track of all the clients and make sure to close them if the user did not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org