[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7146: [AIRFLOW-6541] Use EmrJobFlowSensor for other states

[GitBox <gi...@apache.org>]

nuclearpinguin commented on a change in pull request #7146: [AIRFLOW-6541] Use EmrJobFlowSensor for other states
URL: https://github.com/apache/airflow/pull/7146#discussion_r367498157
 
 

 ##########
 File path: airflow/contrib/sensors/emr_step_sensor.py
 ##########
 @@ -16,52 +16,102 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+
 from airflow.contrib.hooks.emr_hook import EmrHook
 from airflow.contrib.sensors.emr_base_sensor import EmrBaseSensor
 from airflow.utils.decorators import apply_defaults
 
 
 class EmrStepSensor(EmrBaseSensor):
     """
-    Asks for the state of the step until it reaches a terminal state.
+    Asks for the state of the step until it reaches any of the target states.
     If it fails the sensor errors, failing the task.
 
+    With the default target states, sensor waits step to be completed.
+
     :param job_flow_id: job_flow_id which contains the step check the state of
     :type job_flow_id: str
+
 
 Review comment:
   We rather do not use new line here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services