You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2007/01/13 00:58:27 UTC
[jira] Created: (HADOOP-889) DFS unit tests have duplicate code
DFS unit tests have duplicate code
----------------------------------
Key: HADOOP-889
URL: https://issues.apache.org/jira/browse/HADOOP-889
Project: Hadoop
Issue Type: Improvement
Components: test
Affects Versions: 0.10.1
Reporter: Doug Cutting
Priority: Minor
A number of the DFS-related unit tests have a bunch of copied code. These include TestRestartDFS, TestFileCorruption, TestFsck and TestCopyFiles. Even within each test there is a lot of duplicated code. Maintaining these as APIs evolve is arduous. They should instead use a common base class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (HADOOP-889) DFS unit tests have duplicate
code
Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HADOOP-889 started by Milind Bhandarkar.
> DFS unit tests have duplicate code
> ----------------------------------
>
> Key: HADOOP-889
> URL: https://issues.apache.org/jira/browse/HADOOP-889
> Project: Hadoop
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.10.1
> Reporter: Doug Cutting
> Assigned To: Milind Bhandarkar
> Priority: Minor
>
> A number of the DFS-related unit tests have a bunch of copied code. These include TestRestartDFS, TestFileCorruption, TestFsck and TestCopyFiles. Even within each test there is a lot of duplicated code. Maintaining these as APIs evolve is arduous. They should instead use a common base class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-889) DFS unit tests have duplicate code
Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Milind Bhandarkar updated HADOOP-889:
-------------------------------------
Fix Version/s: 0.12.0
Status: Patch Available (was: In Progress)
> DFS unit tests have duplicate code
> ----------------------------------
>
> Key: HADOOP-889
> URL: https://issues.apache.org/jira/browse/HADOOP-889
> Project: Hadoop
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.10.1
> Reporter: Doug Cutting
> Assigned To: Milind Bhandarkar
> Priority: Minor
> Fix For: 0.12.0
>
> Attachments: dfs-tests.patch
>
>
> A number of the DFS-related unit tests have a bunch of copied code. These include TestRestartDFS, TestFileCorruption, TestFsck and TestCopyFiles. Even within each test there is a lot of duplicated code. Maintaining these as APIs evolve is arduous. They should instead use a common base class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-889) DFS unit tests have duplicate code
Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Milind Bhandarkar reassigned HADOOP-889:
----------------------------------------
Assignee: Milind Bhandarkar
> DFS unit tests have duplicate code
> ----------------------------------
>
> Key: HADOOP-889
> URL: https://issues.apache.org/jira/browse/HADOOP-889
> Project: Hadoop
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.10.1
> Reporter: Doug Cutting
> Assigned To: Milind Bhandarkar
> Priority: Minor
>
> A number of the DFS-related unit tests have a bunch of copied code. These include TestRestartDFS, TestFileCorruption, TestFsck and TestCopyFiles. Even within each test there is a lot of duplicated code. Maintaining these as APIs evolve is arduous. They should instead use a common base class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-889) DFS unit tests have duplicate code
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473258 ]
Hadoop QA commented on HADOOP-889:
----------------------------------
+1, because http://issues.apache.org/jira/secure/attachment/12351191/dfs-tests.patch applied and successfully tested against trunk revision r507276.
> DFS unit tests have duplicate code
> ----------------------------------
>
> Key: HADOOP-889
> URL: https://issues.apache.org/jira/browse/HADOOP-889
> Project: Hadoop
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.10.1
> Reporter: Doug Cutting
> Assigned To: Milind Bhandarkar
> Priority: Minor
> Fix For: 0.12.0
>
> Attachments: dfs-tests.patch
>
>
> A number of the DFS-related unit tests have a bunch of copied code. These include TestRestartDFS, TestFileCorruption, TestFsck and TestCopyFiles. Even within each test there is a lot of duplicated code. Maintaining these as APIs evolve is arduous. They should instead use a common base class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-889) DFS unit tests have duplicate code
Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Milind Bhandarkar updated HADOOP-889:
-------------------------------------
Attachment: dfs-tests.patch
Attached a patch that separates common code used by various dfs tests into a separate utility class.
> DFS unit tests have duplicate code
> ----------------------------------
>
> Key: HADOOP-889
> URL: https://issues.apache.org/jira/browse/HADOOP-889
> Project: Hadoop
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.10.1
> Reporter: Doug Cutting
> Assigned To: Milind Bhandarkar
> Priority: Minor
> Fix For: 0.12.0
>
> Attachments: dfs-tests.patch
>
>
> A number of the DFS-related unit tests have a bunch of copied code. These include TestRestartDFS, TestFileCorruption, TestFsck and TestCopyFiles. Even within each test there is a lot of duplicated code. Maintaining these as APIs evolve is arduous. They should instead use a common base class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-889) DFS unit tests have duplicate code
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-889:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Milind!
> DFS unit tests have duplicate code
> ----------------------------------
>
> Key: HADOOP-889
> URL: https://issues.apache.org/jira/browse/HADOOP-889
> Project: Hadoop
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.10.1
> Reporter: Doug Cutting
> Assigned To: Milind Bhandarkar
> Priority: Minor
> Fix For: 0.12.0
>
> Attachments: dfs-tests.patch
>
>
> A number of the DFS-related unit tests have a bunch of copied code. These include TestRestartDFS, TestFileCorruption, TestFsck and TestCopyFiles. Even within each test there is a lot of duplicated code. Maintaining these as APIs evolve is arduous. They should instead use a common base class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.