You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Dan Poirier <po...@pobox.com> on 2009/07/09 15:09:59 UTC
Re: svn commit: r790589 - /httpd/test/framework/trunk/t/security/CVE-2009-1890.t
jorton@apache.org writes:
> Author: jorton
> Date: Thu Jul 2 13:42:12 2009
> New Revision: 790589
>
> URL: http://svn.apache.org/viewvc?rev=790589&view=rev
> Log:
> - add test case for CVE-2009-1890
>
> Added:
> httpd/test/framework/trunk/t/security/CVE-2009-1890.t (with props)
I've been looking at this test and I could use some help understanding
it.
The test doesn't seem to do what the vulnerability description talks
about. The vulnerability talks about sending additional data after
sending Content-length bytes of request body, where this test sends a
request body of the right length, just in two parts with a pause in
between.
--
Dan Poirier <po...@pobox.com>
Re: svn commit: r790589 -
/httpd/test/framework/trunk/t/security/CVE-2009-1890.t
Posted by Joe Orton <jo...@redhat.com>.
On Thu, Jul 09, 2009 at 09:48:29AM -0400, Dan Poirier wrote:
> So if the content-length was parsed correctly, but the vulnerability
> related to additional data wasn't fixed, this test would still pass?
> (Since then we're not sending any more data than expected?)
That is phrased almost as if there are two separate vulnerabilities
here, which is not known to be the case. To ensure there is no
misunderstanding here:
The root cause of CVE-2009-1890 is that stream_reqbody_cl() would
convert the Content-Length from octal rather than decimal for the case
of a C-L header with leading zeroes. Fixing that bug fixes the security
issue.
A second change was also committed, to break out from the loop in the
case of a mismatch between length of received data and expected data.
That change is a safety and correctness fix; it is not strictly
necessary to fix any security vulnerability, so far as I am aware.
The test case does not trigger the error path added in the second
change, and I know of no way to trigger that error path with the current
code. I would certainly not recommend that anybody omit the second
change if backporting the fix, however.
Hope that is precise enough ;)
Regards, Joe
RE: svn commit: r790589 - /httpd/test/framework/trunk/t/security/CVE-2009-1890.t
Posted by "Plüm, Rüdiger, VF-Group" <ru...@vodafone.com>.
> -----Original Message-----
> From: Dan Poirier [mailto:poirier@pobox.com]
> Sent: Donnerstag, 9. Juli 2009 15:48
> To: dev@httpd.apache.org
> Subject: Re: svn commit: r790589 -
> /httpd/test/framework/trunk/t/security/CVE-2009-1890.t
>
> "Plüm, Rüdiger, VF-Group" <ru...@vodafone.com> writes:
> >> -----Original Message-----
> >> From: Dan Poirier
> >> Sent: Donnerstag, 9. Juli 2009 15:10
> >> To: dev@httpd.apache.org
> >> Subject: Re: svn commit: r790589 -
> >> /httpd/test/framework/trunk/t/security/CVE-2009-1890.t
> >>
> >> The test doesn't seem to do what the vulnerability
> description talks
> >> about. The vulnerability talks about sending additional data after
> >> sending Content-length bytes of request body, where this
> test sends a
> >> request body of the right length, just in two parts with a pause in
> >> between.
> >
> > It adds a leading '0' to the content-length header causing
> the old code
> > to interpret the content-length as being an octal number.
> > Interpreting the content-length as octal results in a much
> lower content length
> > as if it was interpreted as a decimal number.
>
> So if the content-length was parsed correctly, but the vulnerability
> related to additional data wasn't fixed, this test would still pass?
> (Since then we're not sending any more data than expected?)
IMHO correct.
Regards
Rüdiger
Re: svn commit: r790589 - /httpd/test/framework/trunk/t/security/CVE-2009-1890.t
Posted by Dan Poirier <po...@pobox.com>.
"Plüm, Rüdiger, VF-Group" <ru...@vodafone.com> writes:
>> -----Original Message-----
>> From: Dan Poirier
>> Sent: Donnerstag, 9. Juli 2009 15:10
>> To: dev@httpd.apache.org
>> Subject: Re: svn commit: r790589 -
>> /httpd/test/framework/trunk/t/security/CVE-2009-1890.t
>>
>> The test doesn't seem to do what the vulnerability description talks
>> about. The vulnerability talks about sending additional data after
>> sending Content-length bytes of request body, where this test sends a
>> request body of the right length, just in two parts with a pause in
>> between.
>
> It adds a leading '0' to the content-length header causing the old code
> to interpret the content-length as being an octal number.
> Interpreting the content-length as octal results in a much lower content length
> as if it was interpreted as a decimal number.
So if the content-length was parsed correctly, but the vulnerability
related to additional data wasn't fixed, this test would still pass?
(Since then we're not sending any more data than expected?)
--
Dan Poirier <po...@pobox.com>
RE: svn commit: r790589 - /httpd/test/framework/trunk/t/security/CVE-2009-1890.t
Posted by "Plüm, Rüdiger, VF-Group" <ru...@vodafone.com>.
> -----Original Message-----
> From: Dan Poirier
> Sent: Donnerstag, 9. Juli 2009 15:10
> To: dev@httpd.apache.org
> Subject: Re: svn commit: r790589 -
> /httpd/test/framework/trunk/t/security/CVE-2009-1890.t
>
> jorton@apache.org writes:
>
> > Author: jorton
> > Date: Thu Jul 2 13:42:12 2009
> > New Revision: 790589
> >
> > URL: http://svn.apache.org/viewvc?rev=790589&view=rev
> > Log:
> > - add test case for CVE-2009-1890
> >
> > Added:
> > httpd/test/framework/trunk/t/security/CVE-2009-1890.t
> (with props)
>
> I've been looking at this test and I could use some help understanding
> it.
>
> The test doesn't seem to do what the vulnerability description talks
> about. The vulnerability talks about sending additional data after
> sending Content-length bytes of request body, where this test sends a
> request body of the right length, just in two parts with a pause in
> between.
It adds a leading '0' to the content-length header causing the old code
to interpret the content-length as being an octal number.
Interpreting the content-length as octal results in a much lower content length
as if it was interpreted as a decimal number.
Regards
Rüdiger