You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sdap.apache.org by "RKuttruff (via GitHub)" <gi...@apache.org> on 2023/07/05 23:04:46 UTC

[GitHub] [incubator-sdap-nexus] RKuttruff opened a new pull request, #263: Fix for cdmslist bug in pagination PR

RKuttruff opened a new pull request, #263:
URL: https://github.com/apache/incubator-sdap-nexus/pull/263

   Fixes a bug in #261 which causes the `/cdmslist` endpoint to break. Bug was due to the endpoint producing a `DomsQueryResults` object. The pagination PR makes an assumption that one of the fields of this object will be given as non-null, which doesn't apply to the result data for this endpoint. This PR provides the endpoint with its own result type, which should remove all the unused/empty/misleading fields that come with using `DomsQueryResults` or even the base `NexusResults` class.
   The changes in this PR will also allow for the closure of #177, as the issue handled by it will no longer exist.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-sdap-nexus] skorper merged pull request #263: Fix for cdmslist bug in pagination PR

Posted by "skorper (via GitHub)" <gi...@apache.org>.
skorper merged PR #263:
URL: https://github.com/apache/incubator-sdap-nexus/pull/263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org