You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/22 06:44:47 UTC
[GitHub] [incubator-kyuubi] zhanqian-1993 opened a new pull request, #2443: [KYUUBI #2432][DOCS] button "Download" is invalid
zhanqian-1993 opened a new pull request, #2443:
URL: https://github.com/apache/incubator-kyuubi/pull/2443
#2432
### _How was this patch tested?_
rerun “build_document.md” to generate html and test download button click jumping website.
here is ui
<img width="1075" alt="image" src="https://user-images.githubusercontent.com/14138772/164618499-6c05abb8-a834-4e5a-9337-ac183b4c70c9.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhanqian-1993 commented on a diff in pull request #2443: [KYUUBI #2432][DOCS] button "Download" is invalid
Posted by GitBox <gi...@apache.org>.
zhanqian-1993 commented on code in PR #2443:
URL: https://github.com/apache/incubator-kyuubi/pull/2443#discussion_r855827176
##########
docs/quick_start/quick_start.md:
##########
@@ -31,7 +31,7 @@
Currently, Apache Kyuubi maintains all its releases on our official [website](https://kyuubi.apache.org/releases.html).
You can get the most recent stable release of Apache Kyuubi here:
-<a class="github-button" href="https://kyuubi.apache.org/releases.html" data-color-scheme="no-preference: light; light: dark; dark: light;" data-icon="octicon-download" data-size="large" aria-label="Download Kyuubi">Download</a>
Review Comment:
I don't find the remove way in https://github.com/apache/incubator-kyuubi/pull/2443/files#diff-3a40f1d689268de6891f7d00b2c939bf0f67c9701bc8cfcc29869a134f02b472L18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #2443: [KYUUBI #2432][DOCS] button "Download" is invalid
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #2443: [KYUUBI #2432][DOCS] button "Download" is invalid
URL: https://github.com/apache/incubator-kyuubi/pull/2443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2443: [KYUUBI #2432][DOCS] button "Download" is invalid
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2443:
URL: https://github.com/apache/incubator-kyuubi/pull/2443#issuecomment-1106148240
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2443?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2443](https://codecov.io/gh/apache/incubator-kyuubi/pull/2443?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4dafc29) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/14f675d28841cb7e049af187fcd1a339e24ffc6d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (14f675d) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2443 +/- ##
============================================
- Coverage 63.20% 63.19% -0.01%
Complexity 69 69
============================================
Files 366 366
Lines 17438 17438
Branches 2341 2341
============================================
- Hits 11021 11020 -1
Misses 5393 5393
- Partials 1024 1025 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2443?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../kyuubi/credentials/HadoopCredentialsManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2443/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BDcmVkZW50aWFsc01hbmFnZXIuc2NhbGE=) | `93.12% <0.00%> (-0.77%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2443/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `80.12% <0.00%> (-0.63%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2443/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `96.29% <0.00%> (+1.85%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2443?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2443?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [14f675d...4dafc29](https://codecov.io/gh/apache/incubator-kyuubi/pull/2443?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhanqian-1993 commented on a diff in pull request #2443: [KYUUBI #2432][DOCS] button "Download" is invalid
Posted by GitBox <gi...@apache.org>.
zhanqian-1993 commented on code in PR #2443:
URL: https://github.com/apache/incubator-kyuubi/pull/2443#discussion_r855844866
##########
docs/quick_start/quick_start.md:
##########
@@ -31,7 +31,7 @@
Currently, Apache Kyuubi maintains all its releases on our official [website](https://kyuubi.apache.org/releases.html).
You can get the most recent stable release of Apache Kyuubi here:
-<a class="github-button" href="https://kyuubi.apache.org/releases.html" data-color-scheme="no-preference: light; light: dark; dark: light;" data-icon="octicon-download" data-size="large" aria-label="Download Kyuubi">Download</a>
Review Comment:
oh, thank you. The github can not jump to line 18 using this link. I misunderstood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2443: [KYUUBI #2432][DOCS] button "Download" is invalid
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #2443:
URL: https://github.com/apache/incubator-kyuubi/pull/2443#issuecomment-1106228952
@zhanqian-1993 welcome to Kyuubi !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2443: [KYUUBI #2432][DOCS] button "Download" is invalid
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2443:
URL: https://github.com/apache/incubator-kyuubi/pull/2443#discussion_r855814855
##########
docs/quick_start/quick_start.md:
##########
@@ -31,7 +31,7 @@
Currently, Apache Kyuubi maintains all its releases on our official [website](https://kyuubi.apache.org/releases.html).
You can get the most recent stable release of Apache Kyuubi here:
-<a class="github-button" href="https://kyuubi.apache.org/releases.html" data-color-scheme="no-preference: light; light: dark; dark: light;" data-icon="octicon-download" data-size="large" aria-label="Download Kyuubi">Download</a>
Review Comment:
we can remove https://github.com/apache/incubator-kyuubi/pull/2443/files#diff-3a40f1d689268de6891f7d00b2c939bf0f67c9701bc8cfcc29869a134f02b472L18 too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhanqian-1993 commented on a diff in pull request #2443: [KYUUBI #2432][DOCS] button "Download" is invalid
Posted by GitBox <gi...@apache.org>.
zhanqian-1993 commented on code in PR #2443:
URL: https://github.com/apache/incubator-kyuubi/pull/2443#discussion_r855826354
##########
docs/quick_start/quick_start.md:
##########
@@ -31,7 +31,7 @@
Currently, Apache Kyuubi maintains all its releases on our official [website](https://kyuubi.apache.org/releases.html).
You can get the most recent stable release of Apache Kyuubi here:
-<a class="github-button" href="https://kyuubi.apache.org/releases.html" data-color-scheme="no-preference: light; light: dark; dark: light;" data-icon="octicon-download" data-size="large" aria-label="Download Kyuubi">Download</a>
Review Comment:
sorry, this's my first PR for Kyuubi. I don't understand what you mean. Is it because of duplicate commit the same code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2443: [KYUUBI #2432][DOCS] button "Download" is invalid
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2443:
URL: https://github.com/apache/incubator-kyuubi/pull/2443#discussion_r855827851
##########
docs/quick_start/quick_start.md:
##########
@@ -31,7 +31,7 @@
Currently, Apache Kyuubi maintains all its releases on our official [website](https://kyuubi.apache.org/releases.html).
You can get the most recent stable release of Apache Kyuubi here:
-<a class="github-button" href="https://kyuubi.apache.org/releases.html" data-color-scheme="no-preference: light; light: dark; dark: light;" data-icon="octicon-download" data-size="large" aria-label="Download Kyuubi">Download</a>
Review Comment:
I mean remove the line 18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2443: [KYUUBI #2432][DOCS] button "Download" is invalid
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #2443:
URL: https://github.com/apache/incubator-kyuubi/pull/2443#issuecomment-1106228250
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org