You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/19 22:10:27 UTC

[jira] [Commented] (BEAM-1285) Apache Rat Plugin should list files with invalid licenses in the console

    [ https://issues.apache.org/jira/browse/BEAM-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830699#comment-15830699 ] 

ASF GitHub Bot commented on BEAM-1285:
--------------------------------------

GitHub user lukecwik opened a pull request:

    https://github.com/apache/beam/pull/1799

    [BEAM-1285] Apache rat plugin will print out files with unapproved licenses to console

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam apache_rat

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1799.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1799
    
----
commit bd7a73a735e7b9d3b6c8f2e4dadee87d8db1c321
Author: Luke Cwik <lc...@google.com>
Date:   2017-01-19T22:07:46Z

    [BEAM-1285] Apache rat plugin will print out files with unapproved licenses to console

----


> Apache Rat Plugin should list files with invalid licenses in the console
> ------------------------------------------------------------------------
>
>                 Key: BEAM-1285
>                 URL: https://issues.apache.org/jira/browse/BEAM-1285
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>
> The rat error report doesn't list the files with unapproved licenses in Jenkins making it difficult to diagnose without rerunning locally.
> Example error message:
> 2017-01-18T23:29:03.041 [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project beam-parent: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/target/beam-parent-0.5.0-incubating-SNAPSHOT.rat -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project beam-parent: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/target/beam-parent-0.5.0-incubating-SNAPSHOT.rat



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)