You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "rmuir (via GitHub)" <gi...@apache.org> on 2025/06/29 13:24:22 UTC

[I] configure third-party javadocs via gradlew eclipse [lucene]

rmuir opened a new issue, #14865:
URL: https://github.com/apache/lucene/issues/14865

   ### Description
   
   Currently, gradlew eclipse creates a `.classpath` file, but it only contains jars of `kind="lib"`. 
   
   This means there's e.g. no documentation for third-party libs. Not much of a problem considering lucene doesn't interact with third-party libraries, it only impacts a small percentage of the code.
   
   But there's cases where we attach to third-party APIs and the improved editor support would really help: particularly the gradle api. The gradle tasks in java work almost perfectly with eclipse/vscode/vim/etc, except for the docs.
   
   Last time I looked into this, my theory was that gradlew eclipse task actually adds this stuff, but we might be accidentally filtering it out with our logic. I'm gonna take another round at it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] configure third-party javadocs via gradlew eclipse [lucene]

Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir closed issue #14865: configure third-party javadocs via gradlew eclipse
URL: https://github.com/apache/lucene/issues/14865


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] configure third-party javadocs via gradlew eclipse [lucene]

Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on issue #14865:
URL: https://github.com/apache/lucene/issues/14865#issuecomment-3019807059

   fixed by #14867 thanks to @dweiss


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] configure third-party javadocs via gradlew eclipse [lucene]

Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on issue #14865:
URL: https://github.com/apache/lucene/issues/14865#issuecomment-3016743040

   First step is to get eclipse plugin to download the correct stuff: this isn't happening today because it doesn't actually run on the subprojects.
   
   I add this hack and the `-sources.jar`'s get downloaded to the gradle cache as expected. Of course it trashes checkout with unwanted eclipse configuration for each subproject as it does this. but at least its downloading.
   
   ```
   --- a/build-tools/build-infra/src/main/groovy/lucene.ide.eclipse.gradle
   +++ b/build-tools/build-infra/src/main/groovy/lucene.ide.eclipse.gradle
   @@ -27,6 +27,11 @@ Provider<String> eclipseJavaVersionOption = buildOptions.addOption("eclipse.java
    Provider<String> eclipseErrorsOption = buildOptions.addOption("eclipse.errors", "Sets eclipse IDE lint level (ignore/warning/error)", "warning")
    
    if (gradle.startParameter.taskNames.contains("eclipse")) {
   +  // force it to download source jars
   +  allprojects {
   +    apply plugin: 'eclipse'
   +  }
   +
      project.pluginManager.apply("java-base")
      project.pluginManager.apply("eclipse")
   ```
   
   I think it would be enough to just extend existing hack to look for `-sources.jar` and specify it as `sourcepath=` in the xml to fix this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org