You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by si...@apache.org on 2012/11/30 04:54:15 UTC

svn commit: r1415491 - in /zookeeper/bookkeeper/trunk: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ hedwig-client/src/main/java/org/apache/hedwig/client/api/

Author: sijie
Date: Fri Nov 30 03:54:14 2012
New Revision: 1415491

URL: http://svn.apache.org/viewvc?rev=1415491&view=rev
Log:
BOOKKEEPER-481: Fix javadoc warnings (ivank via sijie)

Modified:
    zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
    zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java
    zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
    zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
    zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/api/Publisher.java

Modified: zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java?rev=1415491&r1=1415490&r2=1415491&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java (original)
+++ zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java Fri Nov 30 03:54:14 2012
@@ -644,7 +644,7 @@ public class BookKeeperAdmin {
      * 
      * @param lh
      *            - ledgerHandle
-     * @param lf
+     * @param ledgerFragment
      *            - LedgerFragment to replicate
      * @param targetBookieAddress
      *            - target Bookie, to where entries should be replicated.

Modified: zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java?rev=1415491&r1=1415490&r2=1415491&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java (original)
+++ zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java Fri Nov 30 03:54:14 2012
@@ -131,7 +131,7 @@ public class LedgerFragment {
     /**
      * Gets the ensemble of fragment
      * 
-     * @return
+     * @return the ensemble for the segment which this fragment is a part of
      */
     public List<InetSocketAddress> getEnsemble() {
         return this.ensemble;

Modified: zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java?rev=1415491&r1=1415490&r2=1415491&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java (original)
+++ zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java Fri Nov 30 03:54:14 2012
@@ -96,8 +96,7 @@ public abstract class AbstractConfigurat
      *
      * @param lmType
      *          Ledger Manager Type
-     * @return void
-     * @deprecated replaced by {@link #setLedgerManagerFactoryClass()}
+     * @deprecated replaced by {@link #setLedgerManagerFactoryClass}
      */
     @Deprecated
     public void setLedgerManagerType(String lmType) {
@@ -121,7 +120,6 @@ public abstract class AbstractConfigurat
      *
      * @param factoryClassName
      *          Ledger Manager Factory Class Name
-     * @return void
      */
     public void setLedgerManagerFactoryClassName(String factoryClassName) {
         setProperty(LEDGER_MANAGER_FACTORY_CLASS, factoryClassName);
@@ -132,7 +130,6 @@ public abstract class AbstractConfigurat
      *
      * @param factoryClass
      *          Ledger Manager Factory Class
-     * @return void
      */
     public void setLedgerManagerFactoryClass(Class<? extends LedgerManagerFactory> factoryClass) {
         setProperty(LEDGER_MANAGER_FACTORY_CLASS, factoryClass.getName());

Modified: zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java?rev=1415491&r1=1415490&r2=1415491&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java (original)
+++ zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java Fri Nov 30 03:54:14 2012
@@ -563,7 +563,7 @@ public class ServerConfiguration extends
      * crashed and therefore fences the ledger, preventing any further writes to
      * that ledger.
      * 
-     * @see LedgerHandle#openLedger
+     * @see org.apache.bookkeeper.client.BookKeeper#openLedger
      */
     public void setOpenLedgerRereplicationGracePeriod(String waitTime) {
         setProperty(OPEN_LEDGER_REREPLICATION_GRACE_PERIOD, waitTime);

Modified: zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/api/Publisher.java
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/api/Publisher.java?rev=1415491&r1=1415490&r2=1415491&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/api/Publisher.java (original)
+++ zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/api/Publisher.java Fri Nov 30 03:54:14 2012
@@ -67,7 +67,8 @@ public interface Publisher {
   /**
    * Publishes a message asynchronously on the given topic.
    * This method, unlike {@link #asyncPublish(ByteString, PubSubProtocol.Message, Callback, Object)},
-   * allows for the callback to retrieve {@link PubSubProtocol.PublishResponse} which was returned by the server.
+   * allows for the callback to retrieve {@link org.apache.hedwig.protocol.PubSubProtocol.PublishResponse}
+   * which was returned by the server.
    *
    *
    *