You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/04/26 20:45:17 UTC
[GitHub] [guacamole-client] mike-jumper opened a new pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
mike-jumper opened a new pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606
This change updates all immediate Java dependencies to their latest stable versions. The only exceptions to this are:
* "mybatis-guice" - this has a more recent stable release (3.12), but that stable release depends on an unstable and incompatible alpha release of SLF4J.
* Libraries that are not bundled, but provided by the servlet container or JVM (Tomcat/Jetty versions of the legacy WebSocket API, various standard JSR annotations, the non-legacy WebSocket API, the servlet API, etc.)
* Webjars (I'll handle updates to all JavaScript dependencies in a separate PR)
This change also adds the "maven-enforcer-plugin" to the build to help ensure that transitive dependencies are sane.
I have avoided overriding dependencies except where needed to:
* Ensure differing versions of transitive dependencies do not clash
* Ensure that we don't end up bundling a large variety of versions of the same utility libraries when versions are backwards compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper edited a comment on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper edited a comment on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-828291851
So, the "invalid byte" error is due to an incompatibility between the BCEL library (used by Tomcat for annotation scanning) and the Java version of the class being scanned. From https://stackoverflow.com/questions/52867430/invalid-byte-tag-in-constant-pool-19-error-message:
> The BCEL library here is used to parse class files when Tomcat scans for annotations. The version that you are using does not support some features in class file format of Java 8, and thus fails when trying to parse the file.
This isn't entirely correct in our case. Our error deals with `module-info.class`, which is apparently a Java 9 thing:
https://openjdk.java.net/jeps/261
As far as I can tell, the jackson-databind library is built for Java 7, regardless of the fact it includes a `module-info.class`.
It may be possible to strip `module-info.class` from the bundled .jar files, though I don't know whether this would hurt anything:
https://stackoverflow.com/questions/56063566/maven-how-to-remove-module-info-class-warning-for-shaded-jar
It's also possible to stop the error by [disabling annotation scanning](https://tomcat.apache.org/migration-7.html#Annotation_scanning), which involves:
* Bumping the required version of the servlet API from 2.5 to 3.0
* Adding `metadata-complete="true"` to the `<web-app>` element of `web.xml`
* Adding an empty `<absolute-ordering/>` element to `web.xml`
...though I don't know whether _that_ would hurt anything either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-833225406
OK - I have now tested the following:
* guacamole-auth-duo
* guacamole-auth-header
* guacamole-auth-jdbc-*
* guacamole-auth-json
* guacamole-auth-ldap
* guacamole-auth-openid
* guacamole-auth-quickconnnect
* guacamole-auth-saml
* guacamole-auth-totp
and all seems well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-828046419
CAS and RADIUS modules check out fine, now - errors are gone and logins work.
Regarding Java/Tomcat, here is the version information:
openjdk version "1.8.0_275"
OpenJDK Runtime Environment (build 1.8.0_275-b01)
OpenJDK 64-Bit Server VM (build 25.275-b01, mixed mode)
Apache Tomcat Version 8.5.9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#discussion_r620700062
##########
File path: doc/licenses/apache-commons-codec-1.15/README
##########
@@ -0,0 +1,8 @@
+Apache Commons Codec (http://commons.apache.org/proper/commons-codec/)
+-----------------------------------------------------------------------
+
+ Version: 1.15
+ From: 'Apache Software Foundation' (http://www.apache.org)
Review comment:
Sure - I can update this where it occurs real quick.
The URL within `NOTICE` was updated only because it's a verbatim copy of the `NOTICE` provided by the library, but `http://www.apache.org/` redirects to `https://www.apache.org/`. Makes sense to follow that intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-827210019
Also, seeing a bunch of these type errors at startup (Tomcat 8):
```
26-Apr-2021 19:43:07.073 SEVERE [localhost-startStop-26] org.apache.catalina.startup.ContextConfig.processAnnotationsJar Unable to process Jar entry [module-info.class] from Jar [file:/opt/tomcat8/webapps/guacamole/WEB-INF/lib/jackson-databind-2.12.2.jar] for annotations
org.apache.tomcat.util.bcel.classfile.ClassFormatException: Invalid byte tag in constant pool: 19
at org.apache.tomcat.util.bcel.classfile.Constant.readConstant(Constant.java:97)
at org.apache.tomcat.util.bcel.classfile.ConstantPool.<init>(ConstantPool.java:54)
at org.apache.tomcat.util.bcel.classfile.ClassParser.readConstantPool(ClassParser.java:174)
at org.apache.tomcat.util.bcel.classfile.ClassParser.parse(ClassParser.java:83)
at org.apache.catalina.startup.ContextConfig.processAnnotationsStream(ContextConfig.java:2053)
at org.apache.catalina.startup.ContextConfig.processAnnotationsJar(ContextConfig.java:2000)
at org.apache.catalina.startup.ContextConfig.processAnnotationsUrl(ContextConfig.java:1970)
at org.apache.catalina.startup.ContextConfig.processAnnotations(ContextConfig.java:1923)
at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1163)
at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:775)
at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:299)
at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:94)
at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5087)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:752)
at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:728)
at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:734)
at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:952)
at org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1823)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-828700609
@necouchman, assuming the BCEL error is non-fatal and the application otherwise deploys successfully, how would you feel about not attempting to avoid the error given that it's a known bug that has since been addressed by Tomcat? I'm apprehensive about updating the expected Java Servlet API from 2.5 to 3.0 and verifying that there are no side effects to disabling annotation processing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#discussion_r621615924
##########
File path: extensions/guacamole-auth-radius/pom.xml
##########
@@ -150,14 +146,15 @@
<version>1.1.5</version>
<exclusions>
- <exclusion>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-api</artifactId>
- </exclusion>
Review comment:
Ah, you're completely right. SLF4J is being pulled into the extension, causing an identity crisis with the version in the webapp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-828725045
@mike-jumper: Yeah, I'm fine with that - I can try to update Tomcat and see what happens, there, but no need for that to block this.
I assume this pull request is good, otherwise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on a change in pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#discussion_r620723547
##########
File path: extensions/guacamole-auth-radius/pom.xml
##########
@@ -150,14 +146,15 @@
<version>1.1.5</version>
<exclusions>
- <exclusion>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-api</artifactId>
- </exclusion>
Review comment:
I don't think you're going to be able to remove this - I think this causes the error I commented about with the conflict in SLF4J.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on a change in pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#discussion_r620724373
##########
File path: extensions/guacamole-auth-cas/pom.xml
##########
@@ -51,13 +51,7 @@
<dependency>
<groupId>org.jasig.cas.client</groupId>
<artifactId>cas-client-core</artifactId>
- <version>3.4.1</version>
- <exclusions>
- <exclusion>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-api</artifactId>
- </exclusion>
- </exclusions>
Review comment:
Seeing similar issues in the CAS module with errors related to slf4j.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-828291851
So, the "invalid byte" error is due to an incompatibility between the BCEL library (used by Tomcat for annotation scanning) and the Java version of the class being scanned. From https://stackoverflow.com/questions/52867430/invalid-byte-tag-in-constant-pool-19-error-message:
> The BCEL library here is used to parse class files when Tomcat scans for annotations. The version that you are using does not support some features in class file format of Java 8, and thus fails when trying to parse the file.
This isn't entirely correct in our case. Our error deals with `module-info.class`, which is apparently a Java 9 thing:
https://openjdk.java.net/jeps/261
As far as I can tell, the jackson-databind library is built for Java 7, regardless of the fact it includes a `module-info.class`.
It may be possible to strip `module-info.class` from the bundled .jar files, though I don't know whether this would hurt anything:
https://stackoverflow.com/questions/56063566/maven-how-to-remove-module-info-class-warning-for-shaded-jar
It's also possible to stop the error by [disabling annotation scanning](https://tomcat.apache.org/migration-7.html#Annotation_scanning), which involves:
* Bumping the required version of the servlet API from 2.5 to 3.0
* Adding `metadata-complete="true"` to the `<web-app>` element of `web.xml`
* Adding an empty `<absolute-ordering/>' element to `web.xml`
...though I don't know whether _that_ would hurt anything either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on a change in pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#discussion_r620645158
##########
File path: doc/licenses/apache-commons-codec-1.15/README
##########
@@ -0,0 +1,8 @@
+Apache Commons Codec (http://commons.apache.org/proper/commons-codec/)
+-----------------------------------------------------------------------
+
+ Version: 1.15
+ From: 'Apache Software Foundation' (http://www.apache.org)
Review comment:
How much do we care about using the HTTPS version of the Apache URL? I ask because the NOTICE file for this version was updated with that URL...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-827208271
Well, off the bat seeing this in the RADIUS module as soon as I try to access the Guacamole logon page:
```
19:34:30.103 [http-nio-8080-exec-191] WARN o.a.g.e.AuthenticationProviderFacade - The "radius" authentication provider has encountered an internal error which will halt the authentication process. If this is unexpected or you are the developer of this authentication provider, you may wish to enable debug-level logging. If this is expected and you wish to ignore such failures in the future, please set "skip-if-unavailable: radius" within your guacamole.properties.
19:34:30.144 [http-nio-8080-exec-191] ERROR o.a.g.rest.RESTExceptionMapper - Unexpected internal error: Unable to provision, see the following errors:
1) [Guice/ErrorInjectingConstructor]: LinkageError: loader constraint violation: when resolving method "org.slf4j.impl.StaticLoggerBinder.getLoggerFactory()Lorg/slf4j/ILoggerFactory;" the class loader (instance of org/apache/guacamole/extension/ExtensionClassLoader) of the current class, org/slf4j/LoggerFactory, and the class loader (instance of org/apache/catalina/loader/ParallelWebappClassLoader) for the method's defining class, org/slf4j/impl/StaticLoggerBinder, have different Class objects for the type org/slf4j/ILoggerFactory used in the signature
at AuthenticationProviderService.<init>(AuthenticationProviderService.java:51)
while locating AuthenticationProviderService
Learn more:
https://github.com/google/guice/wiki/ERROR_INJECTING_CONSTRUCTOR
1 error
======================
Full classname legend:
======================
AuthenticationProviderService: "org.apache.guacamole.auth.radius.AuthenticationProviderService"
========================
End of classname legend:
========================
19:34:30.146 [http-nio-8080-exec-191] DEBUG o.a.g.rest.RESTExceptionMapper - Unexpected error in REST endpoint.
com.google.inject.ProvisionException: Unable to provision, see the following errors:
1) [Guice/ErrorInjectingConstructor]: LinkageError: loader constraint violation: when resolving method "org.slf4j.impl.StaticLoggerBinder.getLoggerFactory()Lorg/slf4j/ILoggerFactory;" the class loader (instance of org/apache/guacamole/extension/ExtensionClassLoader) of the current class, org/slf4j/LoggerFactory, and the class loader (instance of org/apache/catalina/loader/ParallelWebappClassLoader) for the method's defining class, org/slf4j/impl/StaticLoggerBinder, have different Class objects for the type org/slf4j/ILoggerFactory used in the signature
at AuthenticationProviderService.<init>(AuthenticationProviderService.java:51)
while locating AuthenticationProviderService
Learn more:
https://github.com/google/guice/wiki/ERROR_INJECTING_CONSTRUCTOR
1 error
======================
Full classname legend:
======================
AuthenticationProviderService: "org.apache.guacamole.auth.radius.AuthenticationProviderService"
========================
End of classname legend:
========================
at com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:251)
at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1103)
at com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1138)
at org.apache.guacamole.auth.radius.RadiusAuthenticationProvider.authenticateUser(RadiusAuthenticationProvider.java:68)
at org.apache.guacamole.extension.AuthenticationProviderFacade.authenticateUser(AuthenticationProviderFacade.java:190)
at org.apache.guacamole.rest.auth.AuthenticationService.authenticateUser(AuthenticationService.java:174)
at org.apache.guacamole.rest.auth.AuthenticationService.getAuthenticatedUser(AuthenticationService.java:300)
at org.apache.guacamole.rest.auth.AuthenticationService.authenticate(AuthenticationService.java:453)
at org.apache.guacamole.rest.auth.TokenRESTService.createToken(TokenRESTService.java:174)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory.lambda$static$0(ResourceMethodInvocationHandlerFactory.java:52)
at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:124)
at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:167)
at org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$TypeOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:219)
at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:79)
...
Caused by: java.lang.LinkageError: loader constraint violation: when resolving method "org.slf4j.impl.StaticLoggerBinder.getLoggerFactory()Lorg/slf4j/ILoggerFactory;" the class loader (instance of org/apache/guacamole/extension/ExtensionClassLoader) of the current class, org/slf4j/LoggerFactory, and the class loader (instance of org/apache/catalina/loader/ParallelWebappClassLoader) for the method's defining class, org/slf4j/impl/StaticLoggerBinder, have different Class objects for the type org/slf4j/ILoggerFactory used in the signature
at org.slf4j.LoggerFactory.getILoggerFactory(LoggerFactory.java:423)
at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:362)
at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:388)
at org.apache.guacamole.auth.radius.AuthenticationProviderService.<init>(AuthenticationProviderService.java:56)
at org.apache.guacamole.auth.radius.AuthenticationProviderService$$FastClassByGuice$$3893118.GUICE$TRAMPOLINE(<generated>)
at org.apache.guacamole.auth.radius.AuthenticationProviderService$$FastClassByGuice$$3893118.apply(<generated>)
at com.google.inject.internal.DefaultConstructionProxyFactory$FastClassProxy.newInstance(DefaultConstructionProxyFactory.java:82)
at com.google.inject.internal.ConstructorInjector.provision(ConstructorInjector.java:114)
at com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:91)
at com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:296)
at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1100)
... 60 common frames omitted
```
I seem to recall having this issue before with the RADIUS module - seems like one of the `jradius` dependencies pulls in a different version of SLF4J if you don't specify the `provided` tag for that dependency in the `pom.xml` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-827137065
Forgot to mention - these changes also add a new build property, `ignoreLicenseErrors`, which allows errors that occur during the RAT check and `LICENSE` generation to be bypassed for the sake of testing. For example:
mvn -DignoreLicenseErrors=true
This ended up being useful for testing things before having to commit to the upgrade, since committing to the upgrade means re-researching the license that applies to the dependency, verifying the copyright information we have is up-to-date, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-828294724
Aha! The issue with `module-info.class` and BCEL is a known bug in older versions of Tomcat. From https://bz.apache.org/bugzilla/show_bug.cgi?id=60688:
> Fixed in:
> - trunk for 9.0.0.M18 onwards
> - 8.5.x for 8.5.12 onwards
> - 8.0.x for 8.0.42 onwards
> - 7.0.x for 7.0.76 onwards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-827311665
Gah.
Well, the "Invalid byte tag in constant pool: 19" error looks like an issue with that particular Tomcat and Java 8, not necessarily these changes (though if this was working before, I'm not sure what's up there):
https://stackoverflow.com/questions/52867430/invalid-byte-tag-in-constant-pool-19-error-message
I'll double-check CAS and RADIUS for SLF4J - I remember seeing something like that when I tried mybatis-guice 3.12 and reverted to 3.10 when I realized the former was using 2.0.0-alpha1 and was thus incompatible with SLF4J 1.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-827975472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-828836976
I believe so. I'll do a quick regression test of LDAP, etc. and make extra sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman merged pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper edited a comment on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper edited a comment on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-828700609
@necouchman, assuming the BCEL error is non-fatal and the application otherwise deploys successfully, how would you feel about not attempting to avoid the error given that it's a known bug that has since been addressed by Tomcat? I'm apprehensive about updating the expected Java Servlet API from 2.5 to 3.0, disabling annotation processing, and verifying that there are no side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-827187459
> How extensively have you tested the changes, particularly for the various extensions?
So far, I have only tested against MySQL, MariaDB, PostgreSQL, and SQL Server.
> Is that something you need help with? I can probably resurrect some of my old test environments that I used to develop things like SAML and CAS if that would help.
Yes, please. I have no current means to test RADIUS and CAS.
I can readily test LDAP, JSON, and TOTP, and should be able to set things up for SAML, OpenID, and Duo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper edited a comment on pull request #606: GUACAMOLE-773: Update all Java dependencies to latest available stable versions.
Posted by GitBox <gi...@apache.org>.
mike-jumper edited a comment on pull request #606:
URL: https://github.com/apache/guacamole-client/pull/606#issuecomment-827311665
Gah.
Well, the "Invalid byte tag in constant pool: 19" error looks like an issue with that particular Tomcat and Java 8, not necessarily these changes (though if this was working before, I'm not sure what's up there):
https://stackoverflow.com/questions/52867430/invalid-byte-tag-in-constant-pool-19-error-message
I'll double-check CAS and RADIUS for SLF4J - I remember seeing something like that when I tried mybatis-guice 3.12 and reverted to 3.10 when I realized the former was using 2.0.0-alpha1 and was thus incompatible with SLF4J 1.x.
EDIT: Regarding the invalid byte tag error - I'll recheck this, as well. It doesn't make sense that this would suddenly appear, and further searching is mentioning Java 9, issues with Jersey 2.30.1, issues with particular versions of Javaassist, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org