[jira] [Commented] (MINIFICPP-533) Integer comparison mismatch in ListenHTTP

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512210#comment-16512210 ] 

ASF GitHub Bot commented on MINIFICPP-533:
------------------------------------------

GitHub user achristianson opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/358

    MINIFICPP-533 Fixed signed/unsigned integer comparison mismatch

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] If applicable, have you updated the LICENSE file?
    - [x] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-533

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #358
    
----
commit 845fc9f1960c42fe5656a92e309c2eb64d8c8207
Author: Andrew I. Christianson <an...@...>
Date:   2018-06-14T09:13:23Z

    MINIFICPP-533 Fixed signed/unsigned integer comparison mismatch

----


> Integer comparison mismatch in ListenHTTP
> -----------------------------------------
>
>                 Key: MINIFICPP-533
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-533
>             Project: NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>            Priority: Major
>
> Fix the mismatched size types:
>  
> {{In file included from /home/achristianson/workspace/nifi-minifi-cpp/extensions/civetweb/processors/ListenHTTP.cpp:21:0:}}
> {{/home/achristianson/workspace/nifi-minifi-cpp/extensions/civetweb/processors/ListenHTTP.h: In member function ‘virtual int64_t org::apache::nifi::minifi::processors::ListenHTTP::ResponseBodyReadCallback::process(std::shared_ptr<org::apache::nifi::minifi::io::BaseStream>)’:}}
> {{/home/achristianson/workspace/nifi-minifi-cpp/extensions/civetweb/processors/ListenHTTP.h:139:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]}}
> {{ if (num_read != stream->getSize()) {}}
> {{ ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)