You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Graeme Steyn (JIRA)" <ad...@incubator.apache.org> on 2007/01/18 00:09:30 UTC

[jira] Updated: (ADFFACES-359) tr:SelectOneRadio client side validation problem - JavaScript Error - faces-1_2-070102 branch

     [ https://issues.apache.org/jira/browse/ADFFACES-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Graeme Steyn updated ADFFACES-359:
----------------------------------

    Component/s:     (was: Archetype)
    Description: 
Clientside validation does not work for the tr:selectOneRadio component.  If the component is marked as required and no selection is made, then you do not get an error when attempting to navigate to the next page.  No validation message occurs and as the post back is aborted due to the JavaScript error.  There is no visual indication for the problem other than simple remaining on the same page when clicking the next button.   The problem  is reproducable using the following jspx:

<?xml version='1.0' encoding='windows-1252'?>
<jsp:root xmlns:jsp="http://java.sun.com/JSP/Page" version="2.1"
          xmlns:h="http://java.sun.com/jsf/html"
          xmlns:f="http://java.sun.com/jsf/core"
          xmlns:tr="http://myfaces.apache.org/trinidad"
          xmlns:trh="http://myfaces.apache.org/trinidad/html">
  <jsp:output omit-xml-declaration="true" doctype-root-element="html"
              doctype-system="http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"
              doctype-public="-//W3C//DTD XHTML 1.0 Transitional//EN"/>
  <jsp:directive.page contentType="text/html;charset=windows-1252"/>
  <f:view>
    <trh:html>
      <trh:head title="Dialog">
        <meta http-equiv="Content-Type"
              content="text/html; charset=windows-1252"/>
      </trh:head>
      <trh:body>
        <tr:form>
          <tr:panelFormLayout>

      	    <tr:selectOneRadio
              id="effort"
              layout="vertical"
              label="Test"
              required="true">
              <tr:selectItem 
                value="true" 
                label="Yes" />
              <tr:selectItem 
                value="false" 
                label="No" />
            </tr:selectOneRadio>

          </tr:panelFormLayout>

          <tr:panelButtonBar id="pageNav">
            <tr:commandButton
              action="continue"
              text="continue" />
          </tr:panelButtonBar>

        </tr:form>
      </trh:body>
    </trh:html>
  </f:view>
</jsp:root>

A stack trace for the JavaScript using firebug appears as follows:

a0.ownerDocument has no properties       Common11-m7.js (line 4507)
_isShowing                               Common11-m7.js (line 4507)
_setFocus                                Common11-m7.js (line 4240)
_multiValidate                           Common11-m7.js (line 4332)
_j_id6Validator                          quickDetails.jspx(line 42)
_validateForm                            Common11-m7.js (line 3484)
submitForm                               Common11-m7.js (line 3735)
onclick					 quickDetails.jspx (line 1)

The actual code affect appears as:

4505 if(!_agent.isNav&&!_agent.isSafari&&!_agent.isPIE&&!_agent.isBlackBerry)
4506    {
4507    var a2=a0.ownerDocument.defaultView.getComputedStyle(a0,
4508    null);
4509    return((a2["visibility"]!="hidden")&&
4510    (a2["display"]!="none"));
4511}



  was:
Clientside validation does not work for the tr:selectOneRadio component.  If the component is marked as required and no selection is made, then you do not get an error when attempting to navigate to the next page.  No validation message occurs and as the post back is aborted due to the JavaScript error.  There is no visual indication for the problem other than simple remaining on the same page when clicking the next button.   The problem  is reproducable using the following jspx:

<?xml version='1.0' encoding='windows-1252'?>
<jsp:root xmlns:jsp="http://java.sun.com/JSP/Page" version="2.1"
          xmlns:h="http://java.sun.com/jsf/html"
          xmlns:f="http://java.sun.com/jsf/core"
          xmlns:tr="http://myfaces.apache.org/trinidad"
          xmlns:trh="http://myfaces.apache.org/trinidad/html">
  <jsp:output omit-xml-declaration="true" doctype-root-element="html"
              doctype-system="http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"
              doctype-public="http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"/>
  <jsp:directive.page contentType="text/html;charset=windows-1252"/>
  <f:view>
    <trh:html>
      <trh:head title="Dialog">
        <meta http-equiv="Content-Type"
              content="text/html; charset=windows-1252"/>
      </trh:head>
      <trh:body>
        <tr:form>
          <tr:panelFormLayout>

      	    <tr:selectOneRadio
              id="effort"
              layout="vertical"
              label="Test"
              required="true">
              <tr:selectItem 
                value="true" 
                label="Yes" />
              <tr:selectItem 
                value="false" 
                label="No" />
            </tr:selectOneRadio>

          </tr:panelFormLayout>

          <tr:panelButtonBar id="pageNav">
            <tr:commandButton
              action="continue"
              text="continue" />
          </tr:panelButtonBar>

        </tr:form>
      </trh:body>
    </trh:html>
  </f:view>
</jsp:root>

A stack trace for the JavaScript using firebug appears as follows:

a0.ownerDocument has no properties       Common11-m7.js (line 4507)
_isShowing                               Common11-m7.js (line 4507)
_setFocus                                Common11-m7.js (line 4240)
_multiValidate                           Common11-m7.js (line 4332)
_j_id6Validator                          quickDetails.jspx(line 42)
_validateForm                            Common11-m7.js (line 3484)
submitForm                               Common11-m7.js (line 3735)
onclick					 quickDetails.jspx (line 1)

The actual code affect appears as:

4505 if(!_agent.isNav&&!_agent.isSafari&&!_agent.isPIE&&!_agent.isBlackBerry)
4506    {
4507    var a2=a0.ownerDocument.defaultView.getComputedStyle(a0,
4508    null);
4509    return((a2["visibility"]!="hidden")&&
4510    (a2["display"]!="none"));
4511}




> tr:SelectOneRadio client side validation problem - JavaScript Error - faces-1_2-070102 branch
> ---------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-359
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-359
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>         Environment: Facelets 1.1.11 or JSP; 
> Sun Java System Application Server 9_01 patch 1; 
> JDK 1.6.0; 
> JSF 1.2 faces-1_2-070102 branch; 
> JSF RI: jsf-1.2_03-b09-FCS
>            Reporter: Graeme Steyn
>            Priority: Minor
>
> Clientside validation does not work for the tr:selectOneRadio component.  If the component is marked as required and no selection is made, then you do not get an error when attempting to navigate to the next page.  No validation message occurs and as the post back is aborted due to the JavaScript error.  There is no visual indication for the problem other than simple remaining on the same page when clicking the next button.   The problem  is reproducable using the following jspx:
> <?xml version='1.0' encoding='windows-1252'?>
> <jsp:root xmlns:jsp="http://java.sun.com/JSP/Page" version="2.1"
>           xmlns:h="http://java.sun.com/jsf/html"
>           xmlns:f="http://java.sun.com/jsf/core"
>           xmlns:tr="http://myfaces.apache.org/trinidad"
>           xmlns:trh="http://myfaces.apache.org/trinidad/html">
>   <jsp:output omit-xml-declaration="true" doctype-root-element="html"
>               doctype-system="http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"
>               doctype-public="-//W3C//DTD XHTML 1.0 Transitional//EN"/>
>   <jsp:directive.page contentType="text/html;charset=windows-1252"/>
>   <f:view>
>     <trh:html>
>       <trh:head title="Dialog">
>         <meta http-equiv="Content-Type"
>               content="text/html; charset=windows-1252"/>
>       </trh:head>
>       <trh:body>
>         <tr:form>
>           <tr:panelFormLayout>
>       	    <tr:selectOneRadio
>               id="effort"
>               layout="vertical"
>               label="Test"
>               required="true">
>               <tr:selectItem 
>                 value="true" 
>                 label="Yes" />
>               <tr:selectItem 
>                 value="false" 
>                 label="No" />
>             </tr:selectOneRadio>
>           </tr:panelFormLayout>
>           <tr:panelButtonBar id="pageNav">
>             <tr:commandButton
>               action="continue"
>               text="continue" />
>           </tr:panelButtonBar>
>         </tr:form>
>       </trh:body>
>     </trh:html>
>   </f:view>
> </jsp:root>
> A stack trace for the JavaScript using firebug appears as follows:
> a0.ownerDocument has no properties       Common11-m7.js (line 4507)
> _isShowing                               Common11-m7.js (line 4507)
> _setFocus                                Common11-m7.js (line 4240)
> _multiValidate                           Common11-m7.js (line 4332)
> _j_id6Validator                          quickDetails.jspx(line 42)
> _validateForm                            Common11-m7.js (line 3484)
> submitForm                               Common11-m7.js (line 3735)
> onclick					 quickDetails.jspx (line 1)
> The actual code affect appears as:
> 4505 if(!_agent.isNav&&!_agent.isSafari&&!_agent.isPIE&&!_agent.isBlackBerry)
> 4506    {
> 4507    var a2=a0.ownerDocument.defaultView.getComputedStyle(a0,
> 4508    null);
> 4509    return((a2["visibility"]!="hidden")&&
> 4510    (a2["display"]!="none"));
> 4511}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira