[GitHub] [lucene-solr] anshumg commented on a change in pull request #2328: SOLR-15145: System property to control whether base_url is stored in state.json to enable back-compat with older SolrJ versions

[GitBox <gi...@apache.org>]

anshumg commented on a change in pull request #2328:
URL: https://github.com/apache/lucene-solr/pull/2328#discussion_r573145918



##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkNodeProps.java
##########
@@ -118,14 +120,9 @@ public static ZkNodeProps load(byte[] bytes) {
   @Override
   public void write(JSONWriter jsonWriter) {
     // don't write out the base_url if we have a node_name

Review comment:
       Perhaps also add to the comment about the `STORE_BASE_URL` flag ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org