[jira] [Commented] (LUCENE-8206) TestIndexWriterWithThreads has wall-clock time dependency

["Dawid Weiss (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403738#comment-16403738 ] 

Dawid Weiss commented on LUCENE-8206:
-------------------------------------

So this test is pretty ugly in general... I tried to improve wall-time hacks by adding a cyclic barrier instead of a main thread sleep and by removing the forked thread timeout condition entirely: if the test deadlocks, the framework will issue the failure, including stack traces.

I could not get testOpenTwoIndexWritersOnDifferentThreads to *ever* complete. This test is strange... it has assumptions inside (instead of an if statement?). I don't understand what it should be testing and why the assumptions are there, but I didn't take a very close look.

> TestIndexWriterWithThreads has wall-clock time dependency
> ---------------------------------------------------------
>
>                 Key: LUCENE-8206
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8206
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>         Attachments: LUCENE-8206.patch
>
>
> {code}
> final long stopTime = System.currentTimeMillis() + 200;
> {code}
> This can cause failures on slower machines.
> {code}
> Build: https://builds.apache.org/job/Lucene-Solr-Tests-master/2422/
> 3 tests failed.
> FAILED:  org.apache.lucene.index.TestIndexWriterWithThreads.testCloseWithThreads
> Error Message:
> thread failed before indexing a single document
> Stack Trace:
> java.lang.AssertionError: thread failed before indexing a single document
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org