You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2026/07/05 06:07:17 UTC
(superset) branch master updated: fix(dashboard): prevent dashboard crash when applying grain filters (#41700) (#41746)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new d91c5cf09b6 fix(dashboard): prevent dashboard crash when applying grain filters (#41700) (#41746)
d91c5cf09b6 is described below
commit d91c5cf09b6ad218d1aaa32d6c578b8800d04dbe
Author: Durgaprasad M L <du...@gmail.com>
AuthorDate: Sun Jul 5 11:37:11 2026 +0530
fix(dashboard): prevent dashboard crash when applying grain filters (#41700) (#41746)
---
superset-frontend/src/dashboard/util/activeDashboardFilters.ts | 2 +-
.../src/dashboard/util/charts/getFormDataWithExtraFilters.ts | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/superset-frontend/src/dashboard/util/activeDashboardFilters.ts b/superset-frontend/src/dashboard/util/activeDashboardFilters.ts
index 4f0b7d20391..c5c18970e07 100644
--- a/superset-frontend/src/dashboard/util/activeDashboardFilters.ts
+++ b/superset-frontend/src/dashboard/util/activeDashboardFilters.ts
@@ -100,7 +100,7 @@ export function getAppliedFilterValues(
// use cached data if possible
if (!(chartId in appliedFilterValuesByChart)) {
const applicableFilters = Object.entries(filters || activeFilters).filter(
- ([, { scope: chartIds }]) => chartIds.includes(chartId),
+ ([, activeFilter]) => activeFilter?.scope?.includes(chartId),
);
appliedFilterValuesByChart[chartId] = flow(
keyBy(
diff --git a/superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts b/superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts
index ceb583ba644..89f0085c194 100644
--- a/superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts
+++ b/superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts
@@ -459,7 +459,7 @@ export default function getFormDataWithExtraFilters({
let extraData: JsonObject = {};
const filterIdsAppliedOnChart = Object.entries(activeFilters)
- .filter(([, activeFilter]) => activeFilter.scope.includes(chart.id))
+ .filter(([, activeFilter]) => activeFilter?.scope?.includes(chart.id))
.map(([filterId]) => filterId);
if (filterIdsAppliedOnChart.length) {
@@ -474,7 +474,7 @@ export default function getFormDataWithExtraFilters({
const isDeckMultiChart = chart.form_data?.viz_type === 'deck_multi';
const hasLayerScopeInActiveFilters =
passedActiveFilters &&
- Object.values(passedActiveFilters).some(filter => filter.layerScope);
+ Object.values(passedActiveFilters).some(filter => filter?.layerScope);
if (isDeckMultiChart || hasLayerScopeInActiveFilters) {
const filterDataMapping = createFilterDataMapping(