You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/26 17:24:10 UTC

[GitHub] StefanRRichter edited a comment on issue #7123: [FLINK-10865] Add Aliyun OSS file systems without Hadoop dependencies

StefanRRichter edited a comment on issue #7123: [FLINK-10865] Add Aliyun OSS file systems without Hadoop dependencies
URL: https://github.com/apache/flink/pull/7123#issuecomment-441723504
 
 
   Thank you for this contribution. I think overall it looks good to me, in particular I like how detailed your documentation is. My main comments are:
   - Some fixes for the documentation
   - Thinking about a generalized test base for testing the file systems
   
   Please also bring your commits in order so that there is no merge and everything is rebased on the latest master instead. Thanks!
   
   Disclaimer: I also could not try out the test case because I have no access to a Aliyun OSS fs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services