You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by James Holmes <jh...@yahoo.com> on 2002/06/27 02:44:35 UTC
1.1 Config File DTD discrepancy
Was just updating some code in Struts Console and
noticed that the <message-resources> element doesn't
allow for child <set-property> elements. This seems
to be an oversight to me as every other major element
has this.
Shouldn't users be able to set properties on those
classes too? I think so.
I'll fix the DTD and related files if everyone agrees.
-james
james@jamesholmes.com
http://www.jamesholmes.com/struts/
__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: 1.1 Config File DTD discrepancy
Posted by "Craig R. McClanahan" <cr...@apache.org>.
On Wed, 26 Jun 2002, James Holmes wrote:
> Date: Wed, 26 Jun 2002 17:44:35 -0700 (PDT)
> From: James Holmes <jh...@yahoo.com>
> Reply-To: Struts Developers List <st...@jakarta.apache.org>
> To: struts-dev@jakarta.apache.org
> Subject: 1.1 Config File DTD discrepancy
>
> Was just updating some code in Struts Console and
> noticed that the <message-resources> element doesn't
> allow for child <set-property> elements. This seems
> to be an oversight to me as every other major element
> has this.
>
> Shouldn't users be able to set properties on those
> classes too? I think so.
>
> I'll fix the DTD and related files if everyone agrees.
>
+1, plus any other similar omission you see where the implementation class
is pluggable.
It's interesting to note that JSP 2.0 supports a version of this same
design pattern, by allowing you to use nested <jsp:attribute> tags to set
the attributes of a custom tag.
> -james
> james@jamesholmes.com
> http://www.jamesholmes.com/struts/
>
Craig
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: 1.1 Config File DTD discrepancy
Posted by James Holmes <jh...@yahoo.com>.
Will do. I'll take care of both of these issues today
and commit them tonight.
-james
james@jamesholmes.com
http://www.jamesholmes.com/struts/
--- "Craig R. McClanahan" <cr...@apache.org> wrote:
>
>
> On Wed, 26 Jun 2002, James Holmes wrote:
>
> > Date: Wed, 26 Jun 2002 17:44:35 -0700 (PDT)
> > From: James Holmes <jh...@yahoo.com>
> > Reply-To: Struts Developers List
> <st...@jakarta.apache.org>
> > To: struts-dev@jakarta.apache.org
> > Subject: 1.1 Config File DTD discrepancy
> >
> > Was just updating some code in Struts Console and
> > noticed that the <message-resources> element
> doesn't
> > allow for child <set-property> elements. This
> seems
> > to be an oversight to me as every other major
> element
> > has this.
> >
> > Shouldn't users be able to set properties on those
> > classes too? I think so.
> >
> > I'll fix the DTD and related files if everyone
> agrees.
> >
>
> While you are in messing around, I noticed that the
> "roles" attribute is
> missing from the definition of the <action> element.
> Since we support it
> in the underlying ActinoConfig, it certainly makes
> sense to allow it to be
> configured in the DTD -- could you add that as well?
>
> > -james
> > james@jamesholmes.com
> > http://www.jamesholmes.com/struts/
> >
>
> Craig
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: 1.1 Config File DTD discrepancy
Posted by "Craig R. McClanahan" <cr...@apache.org>.
On Wed, 26 Jun 2002, James Holmes wrote:
> Date: Wed, 26 Jun 2002 17:44:35 -0700 (PDT)
> From: James Holmes <jh...@yahoo.com>
> Reply-To: Struts Developers List <st...@jakarta.apache.org>
> To: struts-dev@jakarta.apache.org
> Subject: 1.1 Config File DTD discrepancy
>
> Was just updating some code in Struts Console and
> noticed that the <message-resources> element doesn't
> allow for child <set-property> elements. This seems
> to be an oversight to me as every other major element
> has this.
>
> Shouldn't users be able to set properties on those
> classes too? I think so.
>
> I'll fix the DTD and related files if everyone agrees.
>
While you are in messing around, I noticed that the "roles" attribute is
missing from the definition of the <action> element. Since we support it
in the underlying ActinoConfig, it certainly makes sense to allow it to be
configured in the DTD -- could you add that as well?
> -james
> james@jamesholmes.com
> http://www.jamesholmes.com/struts/
>
Craig
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>