You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/18 08:40:03 UTC
[GitHub] [spark] LuciferYang opened a new pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
LuciferYang opened a new pull request #31230:
URL: https://github.com/apache/spark/pull/31230
### What changes were proposed in this pull request?
`java.io.FIle.toURL` method does not automatically escape characters that are illegal in URLs.
Java doc recommended that new code convert an abstract pathname into a URL by first converting it into a URI, via the `toURI` method, and then converting the URI into a URL via the `URI.toURL` method.
So this pr cleaned up the relevant cases in Spark code.
### Why are the changes needed?
Cleaning up `@Deprecated` Java API usage.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass the Jenkins or GitHub Action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762139326
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38775/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762201650
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134190/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762218726
@HyukjinKwon Let me re-check this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762100028
**[Test build #134190 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134190/testReport)** for PR 31230 at commit [`22376ed`](https://github.com/apache/spark/commit/22376edd9089d95c65350513b2748c3b1ddad34b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762225078
Merged to master and branch-3.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762121762
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38775/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762175384
**[Test build #134190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134190/testReport)** for PR 31230 at commit [`22376ed`](https://github.com/apache/spark/commit/22376edd9089d95c65350513b2748c3b1ddad34b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762221919
https://github.com/apache/spark/blob/78893b8dc96d19db9ae0d63d9db1644a01c9afb0/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala#L1358-L1372
@HyukjinKwon The rest is as above. I don't know if this part of code is still useful.
EDIT: seems `_` is `URI`.
> Are they all instances to fix @LuciferYang?
Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762100028
**[Test build #134190 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134190/testReport)** for PR 31230 at commit [`22376ed`](https://github.com/apache/spark/commit/22376edd9089d95c65350513b2748c3b1ddad34b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762225349
Thanks @LuciferYang.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762218726
@HyukjinKwon Let me check it again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31230:
URL: https://github.com/apache/spark/pull/31230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762237384
thx @HyukjinKwon ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762167915
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38775/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762201650
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134190/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762221919
https://github.com/apache/spark/blob/78893b8dc96d19db9ae0d63d9db1644a01c9afb0/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala#L1358-L1372
@HyukjinKwon The rest is as above. I don't know if this part of code is still useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762167915
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38775/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31230: [SPARK-34151][SQL] Replaces `java.io.File.toURL` with `java.io.File.toURI.toURL`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31230:
URL: https://github.com/apache/spark/pull/31230#issuecomment-762216127
Are they all instances to fix @LuciferYang?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org