You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/10 11:11:42 UTC
[jira] [Commented] (FLINK-5745) Set uncaught exception handler for
Netty threads
[ https://issues.apache.org/jira/browse/FLINK-5745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861115#comment-15861115 ]
ASF GitHub Bot commented on FLINK-5745:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/3293
[FLINK-5745] set an uncaught exception handler for netty threads
This adds a JVM-terminating handler that logs errors from uncaught exceptions
and terminates the process so that critical exceptions are not accidentally
lost and leave the system running in an inconsistent state.
It borrows and re-uses code from @StephanEwen from this PR:
https://github.com/apache/flink/pull/3290
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-5745
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3293.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3293
----
commit b2a11267b76c9202e178a315905f4e06efd00e34
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-02-10T11:04:37Z
[FLINK-5745] set an uncaught exception handler for netty threads
This adds a JVM-terminating handler that logs errors from uncaught exceptions
and terminates the process so that critical exceptions are not accidentally
lost and leave the system running in an inconsistent state.
It borrows and re-uses code from @StephanEwen from this PR:
https://github.com/apache/flink/pull/3290
----
> Set uncaught exception handler for Netty threads
> ------------------------------------------------
>
> Key: FLINK-5745
> URL: https://issues.apache.org/jira/browse/FLINK-5745
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Reporter: Ufuk Celebi
> Priority: Minor
>
> We pass a thread factory for the Netty event loop threads (see {{NettyServer}} and {{NettyClient}}), but don't set an uncaught exception handler. Let's add a JVM terminating handler that exits the process in cause of fatal errors.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)