You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:08:35 UTC
[GitHub] [knox] moresandeep commented on a change in pull request #489: KNOX-2653:- Update Atlas Service definition for knox logout/timeout in KNOX-2625
moresandeep commented on a change in pull request #489:
URL: https://github.com/apache/knox/pull/489#discussion_r699476790
##########
File path: gateway-service-definitions/src/main/resources/services/atlas/2.1.0/rewrite.xml
##########
@@ -32,14 +32,20 @@
<rewrite template="{$frontend[path]}/atlas/"/>
</rule>
- <rule dir="OUT" name="ATLAS/atlas/outbound/login/headers/location">
- <match pattern="*://*:*/login.jsp"/>
- <rewrite template="{$frontend[url]}/atlas/login.jsp"/>
+ <rule dir="OUT" name="ATLAS/atlas/outbound/login/headers/location" flow="OR">
+ <match pattern="*://*:*/login.jsp">
+ <rewrite template="https://{$frontend[addr]}/gateway/knoxsso/knoxauth/logout.jsp?originalUrl={$postfix[url,/atlas/]}" />
+ </match>
+
+ <match pattern="*://*:*/logout.html?{**}">
+ <rewrite template="https://{$frontend[addr]}/gateway/knoxsso/knoxauth/logout.jsp?{**}"/>
Review comment:
Here we are assuming that the cluster name is `gateway` which will not be the case always.
##########
File path: gateway-service-definitions/src/main/resources/services/atlas/2.1.0/rewrite.xml
##########
@@ -32,14 +32,20 @@
<rewrite template="{$frontend[path]}/atlas/"/>
</rule>
- <rule dir="OUT" name="ATLAS/atlas/outbound/login/headers/location">
- <match pattern="*://*:*/login.jsp"/>
- <rewrite template="{$frontend[url]}/atlas/login.jsp"/>
+ <rule dir="OUT" name="ATLAS/atlas/outbound/login/headers/location" flow="OR">
+ <match pattern="*://*:*/login.jsp">
+ <rewrite template="https://{$frontend[addr]}/gateway/knoxsso/knoxauth/logout.jsp?originalUrl={$postfix[url,/atlas/]}" />
Review comment:
Here we are assuming that the cluster name is gateway which will not be the case always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org