[GitHub] [geode] jdeppe-pivotal opened pull request #3149: GEODE-6350: Use MockMvc for testing RegionManagement integration tests

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

- This also moves the tests out of geode-assembly and into geode-web-management

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal closed pull request #3149: GEODE-6350: Use MockMvc for testing RegionManagement integration tests

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by jdeppe-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #3149: GEODE-6350: Use MockMvc for testing RegionManagement integration tests

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

Perhaps, but I think it would be quite a bit of work. I think the annotations already provide some of the benefits of rules - i.e. startup and correct cleanup. It would be a bit weird to turn that into a rule. I've never seen an examples of anyone doing it. I'd rather do it in a separate PR.

[ Full content available at: https://github.com/apache/geode/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #3149: GEODE-6350: Use MockMvc for testing RegionManagement integration tests

["jinmeiliao (GitHub)" <gi...@apache.org>]

I wonder if we can make this a rule instead of a base test class.

[ Full content available at: https://github.com/apache/geode/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org