You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2015/12/29 09:56:31 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/581
ZEPPELIN-544 ] After the restart when setting bug fixes interpreters note paragraphs state.
### What is this PR for?
Restful api - call upon the setting / interpreter id type,
The problem occurs in the status of running Paragraphs.
- Paragraphs status code changes and restart missing
### What type of PR is it?
Bug Fix
### Todos
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-544
### How should this be tested?
Paragraphs running after interpreter config change, save -> click okay on restart dialog
### Screenshots (if appropriate)
#### before
#### after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin bug_fix/interpreter_restart_abort
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/581.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #581
----
commit f6fe21606cf9fd93055a36b1fd5d7a23643addd2
Author: CloverHearts <es...@gmail.com>
Date: 2015-12-29T08:45:26Z
restful api setting-interpreterid bug fix.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-168277485
Forgot to say LGTM. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-168274289
@HeartSaVioR Happy new year, HeartSaVioR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-167918252
@HeartSaVioR Thank you for Feedback. have a nice day!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-168273429
@HeartSaVioR
Your horse may have a point.
But this is a PR for a bug-fix.
I do not want to put undue changes here.
I am concerned that a new bug occurs.
Once I quit the modification here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-167903686
Great for finding missed spot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-168449994
LGTM and merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-168274083
@cloverhearts OK, Don't worry. I'll address it to another issue. :) Happy new year!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-168013136
Minor: How about extracting whole synchronized block to new private method?
Actually setPropertyAndRestart() and restart() takes same logic except setting additional parameter and calling saveToFile().
setPropertyAndRestart() can call saveToFile() safely when new method is executed without InterpreterException. So new private method doesn't need to take care about safeToFile().
Next concern is that how we can unify logic whether two parameters are presented or not.
It would be achieved easily with null check, but someone can think it's not beautiful.
So I'd like to hear our opinions about this suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-168273664
@HeartSaVioR
I agree with your opinion.
But this is a PR for a bug-fix.
I do not want to put undue changes here.
I am concerned that a new bug occurs.
Once I quit the modification here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---