[jira] [Commented] (GEODE-3105) New flow: GetRegions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065660#comment-16065660 ] 

ASF GitHub Bot commented on GEODE-3105:
---------------------------------------

GitHub user WireBaron opened a pull request:

    https://github.com/apache/geode/pull/607

    GEODE-3105: adding GetRegion handler for protobuf protocol

    Added a handler which will catch incoming getRegion requests and will call into the cache's rootRegion and return the names of the region it finds.
    Added unit test verifying hanlder behavior.
    Added integration test verifying module correctness for getRegion.
    
    Signed-off-by: Hitesh Khamesra <hi...@yahoo.com>
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [x] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WireBaron/geode feature/GEODE-3105

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/607.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #607
    
----
commit f2d55db4e3eabfb51d13284c7cb0b0bacf5b2c05
Author: Brian Rowe <br...@pivotal.io>
Date:   2017-06-27T23:15:53Z

    GEODE-3105: adding GetRegion handler for protobuf protocol
    
    Added a handler which will catch incoming getRegion requests and will call into the cache's rootRegion and return the names of the region it finds.
    Added unit test verifying hanlder behavior.
    Added integration test verifying module correctness for getRegion.
    
    Signed-off-by: Brian Rowe <br...@pivotal.io>
    Signed-off-by: Hitesh Khamesra <hi...@yahoo.com>

----


> New flow: GetRegions
> --------------------
>
>                 Key: GEODE-3105
>                 URL: https://issues.apache.org/jira/browse/GEODE-3105
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Brian Baynes
>
> Users of the new client/server protocol need to be able to receive a list of the existing regions.  Implement GetRegions message/handler.  Proto message definition has already been created.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)