You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/12/13 17:26:12 UTC
[GitHub] [incubator-kyuubi] turboFei opened a new pull request, #3975: Batch session event
turboFei opened a new pull request, #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#discussion_r1051759761
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/events/KyuubiOperationEvent.scala:
##########
@@ -81,6 +84,7 @@ object KyuubiOperationEvent {
status.completed,
status.exception,
session.handle.identifier.toString,
- session.user)
+ session.user,
+ session.sessionType.toString)
Review Comment:
now we have two kind of sessions, it is better to post the session type, so that we can group by session type to check the sql/batch operations trend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#discussion_r1051772591
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSessionImpl.scala:
##########
@@ -77,6 +77,8 @@ class KyuubiBatchSessionImpl(
sessionManager.validateBatchConf(batchRequest.getConf.asScala.toMap)
}
+ override lazy val name: Option[String] = Option(batchRequest.getName)
Review Comment:
I think it is not needed to respect `KyuubiConf.SESSION_NAME.key` here
@ulysses-you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#discussion_r1051856705
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSessionImpl.scala:
##########
@@ -77,6 +77,8 @@ class KyuubiBatchSessionImpl(
sessionManager.validateBatchConf(batchRequest.getConf.asScala.toMap)
}
+ override lazy val name: Option[String] = Option(batchRequest.getName)
Review Comment:
please ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on a diff in pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
wForget commented on code in PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#discussion_r1051711188
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -186,7 +186,6 @@ class KyuubiSessionImpl(
override protected def runOperation(operation: Operation): OperationHandle = {
if (operation != launchEngineOp) {
waitForEngineLaunched()
- sessionEvent.totalOperations += 1
Review Comment:
> should we treat launchEngineOp as an operation? cc @wForget
This means whether we should treat `openSession` as an operation, i tend not to treat as an operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#issuecomment-1356058449
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3975](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (806be6d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/eb98f1e2339aba6b02af1af89195f89b52034ebc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb98f1e) will **increase** coverage by `0.07%`.
> The diff coverage is `83.33%`.
```diff
@@ Coverage Diff @@
## master #3975 +/- ##
============================================
+ Coverage 51.96% 52.04% +0.07%
Complexity 13 13
============================================
Files 522 541 +19
Lines 29042 29480 +438
Branches 3887 3939 +52
============================================
+ Hits 15093 15343 +250
- Misses 12575 12729 +154
- Partials 1374 1408 +34
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `78.83% <ø> (+0.87%)` | :arrow_up: |
| [...g/apache/kyuubi/operation/BatchJobSubmission.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vQmF0Y2hKb2JTdWJtaXNzaW9uLnNjYWxh) | `75.75% <66.66%> (-0.98%)` | :arrow_down: |
| [...apache/kyuubi/session/KyuubiBatchSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaUJhdGNoU2Vzc2lvbkltcGwuc2NhbGE=) | `88.37% <100.00%> (+1.78%)` | :arrow_up: |
| [...cala/org/apache/kyuubi/session/KyuubiSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb24uc2NhbGE=) | `100.00% <100.00%> (ø)` | |
| [...client/exception/RetryableKyuubiRestException.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2V4Y2VwdGlvbi9SZXRyeWFibGVLeXV1YmlSZXN0RXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/kyuubi/client/RetryableRestClient.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L1JldHJ5YWJsZVJlc3RDbGllbnQuamF2YQ==) | `48.78% <0.00%> (-24.40%)` | :arrow_down: |
| [...ubi/plugin/spark/authz/serde/tableExtractors.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstYXV0aHovc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvcGx1Z2luL3NwYXJrL2F1dGh6L3NlcmRlL3RhYmxlRXh0cmFjdG9ycy5zY2FsYQ==) | `82.00% <0.00%> (-11.03%)` | :arrow_down: |
| [.../kyuubi/server/mysql/constant/MySQLErrorCode.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvY29uc3RhbnQvTXlTUUxFcnJvckNvZGUuc2NhbGE=) | `13.84% <0.00%> (-6.16%)` | :arrow_down: |
| [...uubi/engine/spark/events/SparkOperationEvent.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9ldmVudHMvU3BhcmtPcGVyYXRpb25FdmVudC5zY2FsYQ==) | `88.88% <0.00%> (-5.56%)` | :arrow_down: |
| [...ache/kyuubi/server/mysql/MySQLCommandHandler.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxDb21tYW5kSGFuZGxlci5zY2FsYQ==) | `77.77% <0.00%> (-4.05%)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/3975/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#issuecomment-1357229973
cc @ulysses-you @wForget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#discussion_r1051758431
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -143,6 +145,13 @@ class BatchJobSubmission(
private def setStateIfNotCanceled(newState: OperationState): Unit = state.synchronized {
if (state != CANCELED) {
setState(newState)
+ applicationInfo.filter(_.id != null).foreach { ai =>
+ session.getSessionEvent.foreach(_.engineId = ai.id)
+ }
+ if (newState == RUNNING) {
+ session.onEngineOpened()
Review Comment:
check the session opened time to confirm that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
wForget commented on PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#issuecomment-1357303146
By the way, I think the `SessionType.SQL` type is confusing, because the `SessionType.SQL` type of Session can also execute scala, python, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#issuecomment-1357367145
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#discussion_r1051316117
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -186,7 +186,6 @@ class KyuubiSessionImpl(
override protected def runOperation(operation: Operation): OperationHandle = {
if (operation != launchEngineOp) {
waitForEngineLaunched()
- sessionEvent.totalOperations += 1
Review Comment:
should we treat launchEngineOp as an operation?
cc @wForget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on a diff in pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
wForget commented on code in PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#discussion_r1051715406
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -143,6 +145,13 @@ class BatchJobSubmission(
private def setStateIfNotCanceled(newState: OperationState): Unit = state.synchronized {
if (state != CANCELED) {
setState(newState)
+ applicationInfo.filter(_.id != null).foreach { ai =>
+ session.getSessionEvent.foreach(_.engineId = ai.id)
+ }
+ if (newState == RUNNING) {
+ session.onEngineOpened()
Review Comment:
Will this be called multiple times?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#discussion_r1051756207
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -143,6 +145,13 @@ class BatchJobSubmission(
private def setStateIfNotCanceled(newState: OperationState): Unit = state.synchronized {
if (state != CANCELED) {
setState(newState)
+ applicationInfo.filter(_.id != null).foreach { ai =>
+ session.getSessionEvent.foreach(_.engineId = ai.id)
+ }
+ if (newState == RUNNING) {
+ session.onEngineOpened()
Review Comment:
One time is expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#discussion_r1051759761
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/events/KyuubiOperationEvent.scala:
##########
@@ -81,6 +84,7 @@ object KyuubiOperationEvent {
status.completed,
status.exception,
session.handle.identifier.toString,
- session.user)
+ session.user,
+ session.sessionType.toString)
Review Comment:
now we have two kinds of session, it is better to post the session type, so that we can group by session type to check the sql/batch operations trend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3975:
URL: https://github.com/apache/incubator-kyuubi/pull/3975#issuecomment-1357307735
> By the way, I think the SessionType.SQL type is confusing, because the SessionType.SQL type of Session can also execute scala, python, etc.
Yes, maybe `INTERACTIVE` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei closed pull request #3975: Support to post batch session/operation event
Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #3975: Support to post batch session/operation event
URL: https://github.com/apache/incubator-kyuubi/pull/3975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org