You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/09/12 02:21:23 UTC

[GitHub] [incubator-livy] yiheng commented on a change in pull request #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer

yiheng commented on a change in pull request #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer
URL: https://github.com/apache/incubator-livy/pull/195#discussion_r323532282
 
 

 ##########
 File path: thriftserver/server/pom.xml
 ##########
 @@ -56,6 +56,25 @@
         </exclusion>
       </exclusions>
     </dependency>
+    <dependency>
+      <groupId>org.apache.hive</groupId>
+      <artifactId>hive-common</artifactId>
 
 Review comment:
   I suggest that we split the [LIVY-609](https://issues.apache.org/jira/browse/LIVY-609)  into sub-tasks. In many scenarios, the basic LDAP function can meet the requirement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services